runtime/vm/flow_graph_allocator.cc - Issue 2796283003: VM: [Kernel] Implement CatchBlockEntryInstr::should_restore_closure_context on all platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_allocator.cc

Issue 2796283003: VM: [Kernel] Implement CatchBlockEntryInstr::should_restore_closure_context on all platforms. (Closed)

Patch Set: Address Zach's comment Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_allocator.cc

diff --git a/runtime/vm/flow_graph_allocator.cc b/runtime/vm/flow_graph_allocator.cc

index 4bc071cc1c6dc0023a4fff5a2016128fe4bf6753..47d9d599df888f53c00e4a97aa59495ba5a4aef6 100644

--- a/runtime/vm/flow_graph_allocator.cc

+++ b/runtime/vm/flow_graph_allocator.cc

@@ -663,6 +663,7 @@ void FlowGraphAllocator::ProcessInitialDefinition(Definition* defn,

#if defined(TARGET_ARCH_DBC)

if (block->IsCatchBlockEntry()) {

if (defn->IsParameter()) {

+ // This must be in sync with FlowGraphCompiler::CatchEntryRegForVariable.

ParameterInstr* param = defn->AsParameter();

intptr_t slot_index = param->index();

AssignSafepoints(defn, range);

« no previous file with comments | « runtime/observatory/tests/service/service.status ('k') | runtime/vm/flow_graph_compiler.h » ('j') | no next file with comments »