ios/chrome/browser/ui/content_suggestions/content_suggestion_extra.h - Issue 2796273002: Display offline availability on ContentSuggestions

Side by Side Diff: ios/chrome/browser/ui/content_suggestions/content_suggestion_extra.h

Issue 2796273002: Display offline availability on ContentSuggestions (Closed)

Patch Set: Add comment Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm ('K') | « ios/chrome/browser/ui/content_suggestions/content_suggestion.mm ('k') | ios/chrome/browser/ui/content_suggestions/content_suggestion_extra.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTION_EXTRA_H_

	6 #define IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTION_EXTRA_H_

	7

	8 #import <Foundation/Foundation.h>

	9

	10 #import "ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.h"

	11

	12 // Extra information available for the ContentSuggestion of type reading list.

	13 @interface ContentSuggestionReadingListExtra : NSObject
	Olivier 2017/04/05 11:58:11 the file name should probably include ReadingList, the file name should probably include ReadingList, or the class name should not contain it. gambard 2017/04/05 12:24:43 The idea is to have a file defining all the extra Show quoted text On 2017/04/05 11:58:11, Olivier Robin wrote: > the file name should probably include ReadingList, or the class name should not > contain it. The idea is to have a file defining all the extra information needed (for Reading List, Bookmarks...). If you think we should have one extra per file I can rename this one. Olivier 2017/04/05 13:07:23 So may be add _builders to the file name? or somet Show quoted text On 2017/04/05 12:24:43, gambard wrote: > On 2017/04/05 11:58:11, Olivier Robin wrote: > > the file name should probably include ReadingList, or the class name should > not > > contain it. > > The idea is to have a file defining all the extra information needed (for > Reading List, Bookmarks...). If you think we should have one extra per file I > can rename this one. So may be add _builders to the file name? or something similar? gambard 2017/04/06 09:28:50 Done. Show quoted text On 2017/04/05 13:07:23, Olivier Robin wrote: > On 2017/04/05 12:24:43, gambard wrote: > > On 2017/04/05 11:58:11, Olivier Robin wrote: > > > the file name should probably include ReadingList, or the class name should > > not > > > contain it. > > > > The idea is to have a file defining all the extra information needed (for > > Reading List, Bookmarks...). If you think we should have one extra per file I > > can rename this one. > > So may be add _builders to the file name? or something similar? Done.
	14

	15 + (ContentSuggestionReadingListExtra*)extraWithStatus:
	Olivier 2017/04/05 13:45:22 reading list status is read/unread. ExtraWithDisti reading list status is read/unread. ExtraWithDistillationStatus? gambard 2017/04/06 09:28:50 Done. Show quoted text On 2017/04/05 13:45:22, Olivier Robin wrote: > reading list status is read/unread. > ExtraWithDistillationStatus? Done.
	16 (ReadingListUIDistillationStatus)status;

	17

	18 // Status of the distillation.

	19 @property(nonatomic, assign) ReadingListUIDistillationStatus status;
	Olivier 2017/04/05 11:58:11 Why not ReadingListSuggestionExtra::ReadingListSug Why not ReadingListSuggestionExtra::ReadingListSuggestionDistilledState? gambard 2017/04/05 12:24:43 Because ReadingListSuggestionExtra::ReadingListSug Show quoted text On 2017/04/05 11:58:11, Olivier Robin wrote: > Why not ReadingListSuggestionExtra::ReadingListSuggestionDistilledState? Because ReadingListSuggestionExtra::ReadingListSuggestionDistilledState is in components and the components files cannot be include from the UI layer (i.e. this file). Olivier 2017/04/05 13:07:23 Why? Is there a circular dependency? Show quoted text On 2017/04/05 12:24:43, gambard wrote: > On 2017/04/05 11:58:11, Olivier Robin wrote: > > Why not ReadingListSuggestionExtra::ReadingListSuggestionDistilledState? > > Because ReadingListSuggestionExtra::ReadingListSuggestionDistilledState is in > components and the components files cannot be include from the UI layer (i.e. > this file). Why? Is there a circular dependency? Olivier 2017/04/05 13:45:22 Ack, discussed offline. Show quoted text On 2017/04/05 13:07:23, Olivier Robin wrote: > On 2017/04/05 12:24:43, gambard wrote: > > On 2017/04/05 11:58:11, Olivier Robin wrote: > > > Why not ReadingListSuggestionExtra::ReadingListSuggestionDistilledState? > > > > Because ReadingListSuggestionExtra::ReadingListSuggestionDistilledState is in > > components and the components files cannot be include from the UI layer (i.e. > > this file). > > Why? > Is there a circular dependency? Ack, discussed offline.
	20

	21 @end

	22

	23 #endif // IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTION_EXTRA_H_

OLD	NEW