Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2796223003: Boolean attributes for Accessibility Object Model Phase 1 (Closed)

Created:
3 years, 8 months ago by dmazzoni
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, eae+blinkwatch, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, rwlbuis, aboxhall, aboxhall+watch_chromium.org, jam, blink-reviews-dom_chromium.org, dglazkov+blink, je_julie, darin-cc_chromium.org, blink-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, sof, yuzo+watch_chromium.org, dmazzoni, haraken, jochen+watch_chromium.org, nektar+watch_chromium.org, nektarios, dtseng+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Boolean attributes for Accessibility Object Model Phase 1 BUG=680345

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+977 lines, -59 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +45 lines, -0 lines 0 comments Download
M content/shell/test_runner/web_ax_object_proxy.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/shell/test_runner/web_ax_object_proxy.cc View 4 chunks +18 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-atomic.html View 1 chunk +23 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-atomic-expected-android.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-atomic-expected-blink.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-atomic-expected-mac.txt View 1 chunk +9 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-atomic-expected-win.txt View 1 chunk +9 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-busy.html View 1 chunk +20 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-busy-expected-android.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-busy-expected-blink.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-busy-expected-mac.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-busy-expected-win.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-disabled.html View 1 chunk +16 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-disabled-expected-android.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-disabled-expected-blink.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-disabled-expected-mac.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-disabled-expected-win.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-expanded.html View 1 chunk +20 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-expanded-expected-android.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-expanded-expected-blink.txt View 1 chunk +7 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-expanded-expected-mac.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-expanded-expected-win.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-hidden.html View 1 chunk +30 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-hidden-expected-android.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-hidden-expected-blink.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-hidden-expected-mac.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-hidden-expected-win.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-modal.html View 1 chunk +17 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-modal-expected-blink.txt View 1 chunk +7 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-modal-expected-win.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-multiline.html View 1 chunk +19 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-multiline-expected-android.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-multiline-expected-blink.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-multiline-expected-mac.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-multiline-expected-win.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-multiselectable.html View 1 chunk +18 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-multiselectable-expected-android.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-multiselectable-expected-blink.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-multiselectable-expected-mac.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-multiselectable-expected-win.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-readonly.html View 1 chunk +14 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-readonly-expected-android.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-readonly-expected-blink.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-readonly-expected-mac.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-readonly-expected-win.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-required.html View 1 chunk +24 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-required-expected-android.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-required-expected-blink.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-required-expected-mac.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-required-expected-win.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-selected.html View 1 chunk +18 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-selected-expected-android.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-selected-expected-blink.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aom/aom-selected-expected-win.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/accessibility/aom-boolean-properties.html View 1 chunk +150 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/AccessibleNode.h View 4 chunks +56 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/AccessibleNode.cpp View 8 chunks +187 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/dom/AccessibleNode.idl View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 3 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 7 chunks +16 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.h View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.cpp View 5 chunks +43 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (4 generated)
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-05 17:43:08 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796223003/1
3 years, 8 months ago (2017-04-05 17:43:48 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-05 18:55:03 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 18:55:04 UTC) #4 
Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698