third_party/WebKit/Source/core/css/CSSValuePool.h - Issue 2796183002: Introduce the nested namespace ::blink::cssvalue, start with CSSColorValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSValuePool.h

Issue 2796183002: Introduce the nested namespace ::blink::cssvalue, start with CSSColorValue. (Closed)

Patch Set: Use an alias for CSSColorValue that is scoped to the class. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSValuePool.h

diff --git a/third_party/WebKit/Source/core/css/CSSValuePool.h b/third_party/WebKit/Source/core/css/CSSValuePool.h

index e07d4518ef83275b55b272c2fb6d371e8455194c..e5a8051a5f310b646d7f4c723b5e61546bc8c835 100644

--- a/third_party/WebKit/Source/core/css/CSSValuePool.h

+++ b/third_party/WebKit/Source/core/css/CSSValuePool.h

@@ -51,6 +51,7 @@ class CORE_EXPORT CSSValuePool

public:

// TODO(sashab): Make all the value pools store const CSSValues.

static const int maximumCacheableIntegerValue = 255;

+ using CSSColorValue = ::blink::cssvalue::CSSColorValue;

dcheng 2017/04/05 06:21:26 Nit: I think ::blink:: can be omitted. (We don't

slangley 2017/04/05 06:45:57 Done

using ColorValueCache = HeapHashMap<unsigned, Member<CSSColorValue>>;

static const unsigned maximumColorCacheSize = 512;

using FontFaceValueCache =