third_party/WebKit/Source/platform/heap/HeapTest.cpp - Issue 2796163002: Migrate WTF::HashCountedSet::add() to ::insert()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/HeapTest.cpp

Issue 2796163002: Migrate WTF::HashCountedSet::add() to ::insert() (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/Database.cpp ('k') | third_party/WebKit/Source/platform/loader/fetch/Resource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/heap/HeapTest.cpp

diff --git a/third_party/WebKit/Source/platform/heap/HeapTest.cpp b/third_party/WebKit/Source/platform/heap/HeapTest.cpp

index ef480e51c97469e2d3a8302d1c3d5a7fb0368071..7affa63f7f28076e9a6cf007f64aab1f254a43bc 100644

--- a/third_party/WebKit/Source/platform/heap/HeapTest.cpp

+++ b/third_party/WebKit/Source/platform/heap/HeapTest.cpp

@@ -2423,8 +2423,8 @@ TEST(HeapTest, HeapCollectionTypes) {

set2->insert(three);

set2->insert(four);

set->insert(oneB);

- set3->add(oneB);

+ set3->insert(oneB);

vector->push_back(oneB);

deque->push_back(oneB);

vector2->push_back(threeB);

@@ -2951,12 +2951,12 @@ TEST(HeapTest, HeapWeakCollectionSimple) {

weakSet->insert(two);

weakSet->insert(keepNumbersAlive[0]);

weakSet->insert(keepNumbersAlive[1]);

- weakCountedSet->add(IntWrapper::create(0));

- weakCountedSet->add(two);

- weakCountedSet->add(keepNumbersAlive[0]);

- weakCountedSet->add(keepNumbersAlive[1]);

+ weakCountedSet->insert(IntWrapper::create(0));

+ weakCountedSet->insert(two);

+ weakCountedSet->insert(keepNumbersAlive[0]);

+ weakCountedSet->insert(keepNumbersAlive[1]);

EXPECT_EQ(1u, weakStrong->size());

EXPECT_EQ(1u, strongWeak->size());

EXPECT_EQ(2u, weakWeak->size());

@@ -3559,9 +3559,9 @@ TEST(HeapTest, HeapWeakCollectionTypes) {

TEST(HeapTest, HeapHashCountedSetToVector) {

HeapHashCountedSet<Member<IntWrapper>> set;

HeapVector<Member<IntWrapper>> vector;

- set.add(new IntWrapper(1));

- set.add(new IntWrapper(2));

+ set.insert(new IntWrapper(1));

+ set.insert(new IntWrapper(2));

copyToVector(set, vector);

EXPECT_EQ(3u, vector.size());

@@ -3579,9 +3579,9 @@ TEST(HeapTest, HeapHashCountedSetToVector) {

TEST(HeapTest, WeakHeapHashCountedSetToVector) {

HeapHashCountedSet<WeakMember<IntWrapper>> set;