Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2796123002: Move tests for parseVariableDeclarationList(), fix for keywords. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move tests for parseVariableDeclarationList(), fix for keywords. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/a5d8f67ea57ebc543c658cf99beb3c96a64eb999

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -142 lines) Patch
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 2 chunks +36 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 5 chunks +113 lines, -140 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-04 16:44:33 UTC) #1
Paul Berry
lgtm
3 years, 8 months ago (2017-04-04 18:02:57 UTC) #2
scheglov
3 years, 8 months ago (2017-04-04 19:41:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a5d8f67ea57ebc543c658cf99beb3c96a64eb999 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698