Harden runtime functions (part 6).

tools/generate-runtime-tests.py

 #!/usr/bin/env python
 # Copyright 2014 the V8 project authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 import re
 import shutil
 import sys
 
 # TODO(jkummerow): Support DATA_VIEW_{G,S}ETTER in runtime.cc
 
 FILENAME = "src/runtime.cc"
 HEADERFILENAME = "src/runtime.h"
 FUNCTION = re.compile("^RUNTIME_FUNCTION\(Runtime_(\w+)")
 ARGSLENGTH = re.compile(".*ASSERT\(.*args\.length\(\) == (\d+)\);")
 FUNCTIONEND = "}\n"
 
 WORKSPACE = os.path.abspath(os.path.join(os.path.dirname(sys.argv[0]), ".."))
 BASEPATH = os.path.join(WORKSPACE, "test", "mjsunit", "runtime-gen")
 THIS_SCRIPT = os.path.relpath(sys.argv[0])
 
 # Counts of functions in each detection state. These are used to assert
 # that the parser doesn't bit-rot. Change the values as needed when you add,
 # remove or change runtime functions, but make sure we don't lose our ability
 # to parse them!
 EXPECTED_FUNCTION_COUNT = 339
-EXPECTED_FUZZABLE_COUNT = 316
+EXPECTED_FUZZABLE_COUNT = 306
 EXPECTED_CCTEST_COUNT = 6
 EXPECTED_UNKNOWN_COUNT = 5
 
 
 # Don't call these at all.
 BLACKLISTED = [
   "Abort",  # Kills the process.
   "AbortJS",  # Kills the process.
   "CompileForOnStackReplacement",  # Riddled with ASSERTs.
   "IS_VAR",  # Not implemented in the runtime.
   "ListNatives",  # Not available in Release mode.
   "SetAllocationTimeout",  # Too slow for fuzzing.
   "SystemBreak",  # Kills (int3) the process.
 
   # These are weird. They violate some invariants when called after
   # bootstrapping.
   "DisableAccessChecks",
   "EnableAccessChecks",
 
-  # Seems to be incompatible with --stress-runs.
+  # The current LiveEdit implementation relies on and messes with internals
+  # in ways that makes it fundamentally unfuzzable :-(
+  "DebugGetLoadedScripts",
+  "DebugSetScriptSource",
+  "LiveEditFindSharedFunctionInfosForScript",
+  "LiveEditFunctionSourceUpdated",
+  "LiveEditGatherCompileInfo",
+  "LiveEditPatchFunctionPositions",
+  "LiveEditReplaceFunctionCode",
+  "LiveEditReplaceRefToNestedFunction",
   "LiveEditReplaceScript",
+  "LiveEditRestartFrame",
+  "SetScriptBreakPoint",
 
   # TODO(jkummerow): Fix these and un-blacklist them!
   "CreateDateTimeFormat",
   "CreateNumberFormat",
 ]
 
 
 # These will always throw.
 THROWS = [
   "CheckExecutionState",  # Needs to hit a break point.
   "CheckIsBootstrapping",  # Needs to be bootstrapping.
   "DebugEvaluate",  # Needs to hit a break point.
   "DebugEvaluateGlobal",  # Needs to hit a break point.
   "DebugIndexedInterceptorElementValue",  # Needs an indexed interceptor.
   "DebugNamedInterceptorPropertyValue",  # Needs a named interceptor.
   "DebugSetScriptSource",  # Checks compilation state of script.
   "GetAllScopesDetails",  # Needs to hit a break point.
   "GetFrameCount",  # Needs to hit a break point.
   "GetFrameDetails",  # Needs to hit a break point.
   "GetRootNaN",  # Needs to be bootstrapping.
   "GetScopeCount",  # Needs to hit a break point.
   "GetScopeDetails",  # Needs to hit a break point.
   "GetStepInPositions",  # Needs to hit a break point.
   "GetTemplateField",  # Needs a {Function,Object}TemplateInfo.
   "GetThreadCount",  # Needs to hit a break point.
   "GetThreadDetails",  # Needs to hit a break point.
   "IsAccessAllowedForObserver",  # Needs access-check-required object.
-  "LiveEditFunctionSourceUpdated",  # Needs a SharedFunctionInfo.
-  "LiveEditPatchFunctionPositions",  # Needs a SharedFunctionInfo.
-  "LiveEditReplaceFunctionCode",  # Needs a SharedFunctionInfo.
-  "LiveEditReplaceRefToNestedFunction",  # Needs a SharedFunctionInfo.
-  "LiveEditRestartFrame",  # Needs to hit a break point.
   "UnblockConcurrentRecompilation"  # Needs --block-concurrent-recompilation.
 ]
 
 
 # Definitions used in CUSTOM_KNOWN_GOOD_INPUT below.
 _BREAK_ITERATOR = (
     "%GetImplFromInitializedIntlObject(new Intl.v8BreakIterator())")
 _COLLATOR = "%GetImplFromInitializedIntlObject(new Intl.Collator('en-US'))"
 _DATETIME_FORMAT = (
     "%GetImplFromInitializedIntlObject(new Intl.DateTimeFormat('en-US'))")
 _NUMBER_FORMAT = (
     "%GetImplFromInitializedIntlObject(new Intl.NumberFormat('en-US'))")
-_SCRIPT = "%DebugGetLoadedScripts()[1]"
 
 
 # Custom definitions for function input that does not throw.
 # Format: "FunctionName": ["arg0", "arg1", ..., argslength].
 # None means "fall back to autodetected value".
 CUSTOM_KNOWN_GOOD_INPUT = {
   "Apply": ["function() {}", None, None, None, None, None],
   "ArrayBufferSliceImpl": [None, None, 0, None],
   "ArrayConcat": ["[1, 'a']", None],
   "BreakIteratorAdoptText": [_BREAK_ITERATOR, None, None],
   "BreakIteratorBreakType": [_BREAK_ITERATOR, None],
   "BreakIteratorCurrent": [_BREAK_ITERATOR, None],
   "BreakIteratorFirst": [_BREAK_ITERATOR, None],
   "BreakIteratorNext": [_BREAK_ITERATOR, None],
   "CompileString": [None, "false", None],
   "CreateBreakIterator": ["'en-US'", "{type: 'string'}", None, None],
   "CreateJSFunctionProxy": [None, "function() {}", None, None, None],
   "CreatePrivateSymbol": ["\"foo\"", None],
   "CreateSymbol": ["\"foo\"", None],
   "DateParseString": [None, "new Array(8)", None],
-  "DebugSetScriptSource": [_SCRIPT, None, None],
   "DefineOrRedefineAccessorProperty": [None, None, "function() {}",
                                        "function() {}", 2, None],
   "GetBreakLocations": [None, 0, None],
   "GetDefaultReceiver": ["function() {}", None],
   "GetImplFromInitializedIntlObject": ["new Intl.NumberFormat('en-US')", None],
   "InternalCompare": [_COLLATOR, None, None, None],
   "InternalDateFormat": [_DATETIME_FORMAT, None, None],
   "InternalDateParse": [_DATETIME_FORMAT, None, None],
   "InternalNumberFormat": [_NUMBER_FORMAT, None, None],
   "InternalNumberParse": [_NUMBER_FORMAT, None, None],
   "IsSloppyModeFunction": ["function() {}", None],
-  "LiveEditFindSharedFunctionInfosForScript": [_SCRIPT, None],
-  "LiveEditGatherCompileInfo": [_SCRIPT, None, None],
   "LoadMutableDouble": ["{foo: 1.2}", None, None],
   "NewObjectFromBound": ["(function() {}).bind({})", None],
   "NumberToRadixString": [None, "2", None],
   "ParseJson": ["\"{}\"", 1],
   "RegExpExecMultiple": [None, None, "['a']", "['a']", None],
   "SetAccessorProperty": [None, None, "undefined", "undefined", None, None,
                           None],
   "SetCreateIterator": [None, "2", None],
   "SetDebugEventListener": ["undefined", None, None],
   "SetFunctionBreakPoint": [None, 200, None, None],
-  "SetScriptBreakPoint": [_SCRIPT, None, 0, None, None],
   "StringBuilderConcat": ["[1, 2, 3]", 3, None, None],
   "StringBuilderJoin": ["['a', 'b']", 4, None, None],
   "StringMatch": [None, None, "['a', 'b']", None],
   "StringNormalize": [None, 2, None],
   "StringReplaceGlobalRegExpWithString": [None, None, None, "['a']", None],
   "TypedArrayInitialize": [None, 6, "new ArrayBuffer(8)", None, 4, None],
   "TypedArrayInitializeFromArrayLike": [None, 6, None, None, None],
   "TypedArraySetFastCases": [None, None, "0", None],
 }
 
@@ skipping 340 matching lines @@
           print("Missing testcase for %s, please run '%s generate'" %
                 (f.name, THIS_SCRIPT))
           error = True
       files = filter(lambda filename: not filename.startswith("."),
                      os.listdir(BASEPATH))
       if (len(files) != len(functions)):
         unexpected_files = set(files) - set([f.Filename() for f in functions])
         for f in unexpected_files:
           print("Unexpected testcase: %s" % os.path.join(BASEPATH, f))
           error = True
+        print("Run '%s generate' to automatically clean these up."
+              % THIS_SCRIPT)
     CheckTestcasesExisting(js_fuzzable_functions)
 
     if error:
       sys.exit(1)
     print("Generated runtime tests: all good.")
     sys.exit(0)
 
   if action == "generate":
     GenerateTestcases(js_fuzzable_functions)
     sys.exit(0)