Issue 279593003: Add an about:blank URLFixerUpperTest test case; cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 279593003: Add an about:blank URLFixerUpperTest test case; cleanup. (Closed)

Created:
6 years, 7 months ago by msw

Modified:
6 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, cbentzel+watch_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add an about:blank URLFixerUpperTest test case; cleanup. URLFixerUpper may potentially mishandle "about:blank". The suspicion arose from crbug.com/371030 investigations. (this unit test case doesn't seem to trigger that, though) BUG=NONE TEST=NONE R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269599

Patch Set 1 #

Patch Set 2 : Additional cleanup. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -131 lines)			Patch
	M	chrome/common/net/url_fixer_upper_unittest.cc	View	1	6 chunks	+102 lines, -131 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/279593003/20001

6 years, 7 months ago (2014-05-09 16:10:51 UTC) #4

Message was sent while issue was closed.

Change committed as 269599

Expand Messages | Collapse Messages