Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1232)

Issue 2795893002: Fix missing partial type in downwards map inference. (Closed)

Created:
3 years, 8 months ago by Leaf
Modified:
3 years, 8 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org, vsm
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix missing partial type in downwards map inference. Fixes https://github.com/dart-lang/sdk/issues/29231 . Fixes regression in inference on map literals in which partial types were being prematurely eliminated during downwards inference. BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/e121d95b1b168a50942a874d66247a3ff72ff892

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -2 lines) Patch
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Leaf
3 years, 8 months ago (2017-04-03 23:21:55 UTC) #2
Jennifer Messerly
lgtm
3 years, 8 months ago (2017-04-03 23:48:45 UTC) #3
Jennifer Messerly
lgtm
3 years, 8 months ago (2017-04-03 23:48:51 UTC) #4
Leaf
3 years, 8 months ago (2017-04-04 00:03:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e121d95b1b168a50942a874d66247a3ff72ff892 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698