Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: services/tracing/service.h

Issue 2795883002: Eliminate OnConnect usage (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/shape_detection/shape_detection_service.cc ('k') | services/tracing/service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/tracing/service.h
diff --git a/services/tracing/service.h b/services/tracing/service.h
index b45d54c8874870c982856017fb67f34a92a94b4e..7260f0a76bc9f823d44f6b979699ba7a983164cc 100644
--- a/services/tracing/service.h
+++ b/services/tracing/service.h
@@ -14,6 +14,7 @@
#include "mojo/public/cpp/bindings/binding_set.h"
#include "mojo/public/cpp/bindings/interface_ptr_set.h"
#include "mojo/public/cpp/bindings/strong_binding.h"
+#include "services/service_manager/public/cpp/binder_registry.h"
#include "services/service_manager/public/cpp/interface_factory.h"
#include "services/service_manager/public/cpp/service.h"
#include "services/tracing/data_sink.h"
@@ -36,8 +37,9 @@ class Service : public service_manager::Service,
private:
// service_manager::Service implementation.
- bool OnConnect(const service_manager::ServiceInfo& remote_info,
- service_manager::InterfaceRegistry* registry) override;
+ void OnBindInterface(const service_manager::ServiceInfo& source_info,
+ const std::string& interface_name,
+ mojo::ScopedMessagePipeHandle interface_pipe) override;
bool OnServiceManagerConnectionLost() override;
// service_manager::InterfaceFactory<mojom::Factory>:
@@ -73,6 +75,7 @@ class Service : public service_manager::Service,
void AllDataCollected();
+ service_manager::BinderRegistry registry_;
mojo::BindingSet<mojom::Factory> bindings_;
std::unique_ptr<DataSink> sink_;
std::vector<std::unique_ptr<Recorder>> recorder_impls_;
« no previous file with comments | « services/shape_detection/shape_detection_service.cc ('k') | services/tracing/service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698