Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: services/navigation/navigation.h

Issue 2795883002: Eliminate OnConnect usage (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/navigation/navigation.h
diff --git a/services/navigation/navigation.h b/services/navigation/navigation.h
index af242e3025785cb32e5833486e81b6f1fc821c9d..d35ad24adbfaeeeb82072b8839787071e14a429b 100644
--- a/services/navigation/navigation.h
+++ b/services/navigation/navigation.h
@@ -11,6 +11,7 @@
#include "content/public/common/connection_filter.h"
#include "mojo/public/cpp/bindings/binding_set.h"
#include "services/navigation/public/interfaces/view.mojom.h"
+#include "services/service_manager/public/cpp/binder_registry.h"
#include "services/service_manager/public/cpp/interface_factory.h"
#include "services/service_manager/public/cpp/service.h"
#include "services/service_manager/public/cpp/service_context_ref.h"
@@ -26,8 +27,9 @@ class Navigation : public service_manager::Service, public mojom::ViewFactory {
private:
// service_manager::Service:
- bool OnConnect(const service_manager::ServiceInfo& remote_info,
- service_manager::InterfaceRegistry* registry) override;
+ void OnBindInterface(const service_manager::ServiceInfo& source_info,
+ const std::string& interface_name,
+ mojo::ScopedMessagePipeHandle interface_pipe) override;
// mojom::ViewFactory:
void CreateView(mojom::ViewClientPtr client,
@@ -43,6 +45,7 @@ class Navigation : public service_manager::Service, public mojom::ViewFactory {
service_manager::ServiceContextRefFactory ref_factory_;
std::set<std::unique_ptr<service_manager::ServiceContextRef>> refs_;
+ service_manager::BinderRegistry registry_;
mojo::BindingSet<mojom::ViewFactory> bindings_;
base::WeakPtrFactory<Navigation> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698