Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Side by Side Diff: services/tracing/service.cc

Issue 2795883002: Eliminate OnConnect usage (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « services/tracing/service.h ('k') | services/ui/demo/mus_demo.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/tracing/service.h" 5 #include "services/tracing/service.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <utility> 10 #include <utility>
11 11
12 #include "base/bind.h" 12 #include "base/bind.h"
13 #include "base/logging.h" 13 #include "base/logging.h"
14 #include "base/memory/ptr_util.h" 14 #include "base/memory/ptr_util.h"
15 #include "base/message_loop/message_loop.h" 15 #include "base/message_loop/message_loop.h"
16 #include "mojo/public/cpp/system/wait.h" 16 #include "mojo/public/cpp/system/wait.h"
17 #include "services/service_manager/public/cpp/interface_registry.h" 17 #include "services/service_manager/public/cpp/service_info.h"
18 18
19 namespace tracing { 19 namespace tracing {
20 20
21 Service::Service() : collector_binding_(this), tracing_active_(false) {} 21 Service::Service() : collector_binding_(this), tracing_active_(false) {
22 registry_.AddInterface<mojom::Factory>(this);
23 registry_.AddInterface<mojom::Collector>(this);
24 registry_.AddInterface<mojom::StartupPerformanceDataCollector>(this);
25 }
22 Service::~Service() {} 26 Service::~Service() {}
23 27
24 bool Service::OnConnect(const service_manager::ServiceInfo& remote_info, 28 void Service::OnBindInterface(const service_manager::ServiceInfo& source_info,
25 service_manager::InterfaceRegistry* registry) { 29 const std::string& interface_name,
26 registry->AddInterface<mojom::Factory>(this); 30 mojo::ScopedMessagePipeHandle interface_pipe) {
27 registry->AddInterface<mojom::Collector>(this); 31 registry_.BindInterface(source_info.identity, interface_name,
28 registry->AddInterface<mojom::StartupPerformanceDataCollector>(this); 32 std::move(interface_pipe));
29 return true;
30 } 33 }
31 34
32 bool Service::OnServiceManagerConnectionLost() { 35 bool Service::OnServiceManagerConnectionLost() {
33 // TODO(beng): This is only required because Service isn't run by 36 // TODO(beng): This is only required because Service isn't run by
34 // ServiceRunner - instead it's launched automatically by the standalone 37 // ServiceRunner - instead it's launched automatically by the standalone
35 // service manager. It shouldn't be. 38 // service manager. It shouldn't be.
36 base::MessageLoop::current()->QuitWhenIdle(); 39 base::MessageLoop::current()->QuitWhenIdle();
37 return false; 40 return false;
38 } 41 }
39 42
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 const GetStartupPerformanceTimesCallback& callback) { 181 const GetStartupPerformanceTimesCallback& callback) {
179 callback.Run(startup_performance_times_.Clone()); 182 callback.Run(startup_performance_times_.Clone());
180 } 183 }
181 184
182 void Service::AllDataCollected() { 185 void Service::AllDataCollected() {
183 recorder_impls_.clear(); 186 recorder_impls_.clear();
184 sink_.reset(); 187 sink_.reset();
185 } 188 }
186 189
187 } // namespace tracing 190 } // namespace tracing
OLDNEW
« no previous file with comments | « services/tracing/service.h ('k') | services/ui/demo/mus_demo.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698