Move implementation of accessibility actions to views::View

ui/views/accessibility/native_view_accessibility_unittest.cc

Index: ui/views/accessibility/native_view_accessibility_unittest.cc
diff --git a/ui/views/accessibility/native_view_accessibility_unittest.cc b/ui/views/accessibility/native_view_accessibility_unittest.cc
index 92eb0035e57b2067f1415f0c2799fa9a4bc4b843..f57d7a217366ff3d457a95ded17d321c27374b05 100644
--- a/ui/views/accessibility/native_view_accessibility_unittest.cc
+++ b/ui/views/accessibility/native_view_accessibility_unittest.cc
@@ -70,6 +70,13 @@ class NativeViewAccessibilityTest : public ViewsTestBase {
         label_accessibility_.get());
   }
 
+  bool SetFocused(NativeViewAccessibilityBase* view_accessibility,
+                  bool focused) {
+    ui::AXActionData data;
+    data.action = focused ? ui::AX_ACTION_FOCUS : ui::AX_ACTION_BLUR;
+    return view_accessibility->AccessibilityPerformAction(data);
+  }
+
  protected:
   views::Widget* widget_;
   TestButton* button_;
@@ -117,17 +124,17 @@ TEST_F(NativeViewAccessibilityTest, WritableFocus) {
   button_->SetFocusBehavior(View::FocusBehavior::ALWAYS);
   EXPECT_EQ(nullptr, button_->GetFocusManager()->GetFocusedView());
   EXPECT_EQ(nullptr, button_accessibility()->GetFocus());
-  EXPECT_TRUE(button_accessibility()->SetFocused(true));
+  EXPECT_TRUE(SetFocused(button_accessibility(), true));
   EXPECT_EQ(button_, button_->GetFocusManager()->GetFocusedView());
   EXPECT_EQ(button_->GetNativeViewAccessible(),
             button_accessibility()->GetFocus());
-  EXPECT_TRUE(button_accessibility()->SetFocused(false));
+  EXPECT_TRUE(SetFocused(button_accessibility(), false));
   EXPECT_EQ(nullptr, button_->GetFocusManager()->GetFocusedView());
   EXPECT_EQ(nullptr, button_accessibility()->GetFocus());
 
   // If not focusable at all, SetFocused() should return false.
   button_->SetEnabled(false);
-  EXPECT_FALSE(button_accessibility()->SetFocused(true));
+  EXPECT_FALSE(SetFocused(button_accessibility(), true));

[tapted, 2017/04/03 23:28:23]

looks like this is failing - `case ui::AX_ACTION_FOCUS` always returns `true` in
view.cc - I'm not sure whether returning false under some condition (or just
`return HasFocus();`) is the right thing there. (alternatively perhaps the
SetFocused() helper could return something like `view_accessibility->GetFocus()
== view_accessibility->GetNativeObject()`)

[dmazzoni, 2017/04/03 23:55:16]

I wasn't quite reproducing the previous behavior, which was to return
false if it's not focusable. Done.

 }
 
 // Subclass of NativeViewAccessibility that destroys itself when its