Move implementation of accessibility actions to views::View

ui/views/view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #define _USE_MATH_DEFINES // For VC++ to get M_PI. This has to be first.
 
 #include "ui/views/view.h"
 
 #include <algorithm>
 #include <cmath>
 #include <memory>
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/containers/adapters.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/stl_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/trace_event/trace_event.h"
 #include "build/build_config.h"
 #include "third_party/skia/include/core/SkRect.h"
+#include "ui/accessibility/ax_action_data.h"
 #include "ui/accessibility/ax_enums.h"
 #include "ui/base/cursor/cursor.h"
 #include "ui/base/dragdrop/drag_drop_types.h"
 #include "ui/base/ime/input_method.h"
 #include "ui/compositor/clip_recorder.h"
 #include "ui/compositor/compositor.h"
 #include "ui/compositor/dip_util.h"
 #include "ui/compositor/layer.h"
 #include "ui/compositor/layer_animator.h"
 #include "ui/compositor/paint_context.h"
 #include "ui/compositor/paint_recorder.h"
 #include "ui/compositor/transform_recorder.h"
 #include "ui/display/screen.h"
+#include "ui/events/base_event_utils.h"
 #include "ui/events/event_target_iterator.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/geometry/point3_f.h"
 #include "ui/gfx/geometry/point_conversions.h"
 #include "ui/gfx/interpolated_transform.h"
 #include "ui/gfx/path.h"
 #include "ui/gfx/scoped_canvas.h"
 #include "ui/gfx/skia_util.h"
 #include "ui/gfx/transform.h"
 #include "ui/native_theme/native_theme.h"
@@ skipping 1342 matching lines @@
 
 // static
 bool View::ExceededDragThreshold(const gfx::Vector2d& delta) {
   return (abs(delta.x()) > GetHorizontalDragThreshold() ||
           abs(delta.y()) > GetVerticalDragThreshold());
 }
 
 // Accessibility----------------------------------------------------------------
 
 bool View::HandleAccessibleAction(const ui::AXActionData& action_data) {
+  switch (action_data.action) {
+    case ui::AX_ACTION_BLUR:
+      if (HasFocus())
+        GetFocusManager()->ClearFocus();
+      return true;
+    case ui::AX_ACTION_DO_DEFAULT: {
+      gfx::Rect rect = GetLocalBounds();
+      gfx::Point center = rect.CenterPoint();

[tapted, 2017/04/03 23:28:23]

nit: const gfx::Point center = GetLocalBounds().CenterPoint(); ?

[dmazzoni, 2017/04/03 23:55:16]

Done.

+      OnMousePressed(ui::MouseEvent(
+          ui::ET_MOUSE_PRESSED, center, center, ui::EventTimeForNow(),
+          ui::EF_LEFT_MOUSE_BUTTON, ui::EF_LEFT_MOUSE_BUTTON));
+      OnMouseReleased(ui::MouseEvent(
+          ui::ET_MOUSE_RELEASED, center, center, ui::EventTimeForNow(),
+          ui::EF_LEFT_MOUSE_BUTTON, ui::EF_LEFT_MOUSE_BUTTON));
+      return true;
+    }
+    case ui::AX_ACTION_FOCUS:
+      if (IsAccessibilityFocusable())
+        RequestFocus();
+      return true;
+    case ui::AX_ACTION_SCROLL_TO_MAKE_VISIBLE:
+      ScrollRectToVisible(GetLocalBounds());
+      return true;
+    case ui::AX_ACTION_SHOW_CONTEXT_MENU:
+      ShowContextMenu(bounds().CenterPoint(), ui::MENU_SOURCE_KEYBOARD);

[tapted, 2017/04/03 23:28:23]

I think ShowContextMenu expects screen coordinates (see
View::ProcessMousePressed)

Something like `bounds().CenterPoint() -> GetBoundsInScreen().CenterPoint()`
looks simplest

[dmazzoni, 2017/04/03 23:55:16]

Good catch! That was a bug from before, I guess nobody noticed.

+      return true;
+    default:
+      // Some actions are handled by subclasses of View.
+      break;
+  }
+
   return false;
 }
 
 gfx::NativeViewAccessible View::GetNativeViewAccessible() {
   if (!native_view_accessibility_)
     native_view_accessibility_ = NativeViewAccessibility::Create(this);
   if (native_view_accessibility_)
     return native_view_accessibility_->GetNativeObject();
   return nullptr;
 }
@@ skipping 1196 matching lines @@
   // Message the RootView to do the drag and drop. That way if we're removed
   // the RootView can detect it and avoid calling us back.
   gfx::Point widget_location(event.location());
   ConvertPointToWidget(this, &widget_location);
   widget->RunShellDrag(this, data, widget_location, drag_operations, source);
   // WARNING: we may have been deleted.
   return true;
 }
 
 }  // namespace views