ui/accessibility/platform/ax_platform_node_delegate.h - Issue 2795843002: Move implementation of accessibility actions to views::View

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/accessibility/platform/ax_platform_node_delegate.h

Issue 2795843002: Move implementation of accessibility actions to views::View (Closed)

Patch Set: Fix native_view_accessibility_unittest too Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility.cc ('k') | ui/views/accessibility/ax_aura_obj_wrapper.h » ('j') | ui/views/accessibility/native_view_accessibility_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef UI_ACCESSIBILITY_PLATFORM_AX_PLATFORM_NODE_DELEGATE_H_	5 #ifndef UI_ACCESSIBILITY_PLATFORM_AX_PLATFORM_NODE_DELEGATE_H_

6 #define UI_ACCESSIBILITY_PLATFORM_AX_PLATFORM_NODE_DELEGATE_H_	6 #define UI_ACCESSIBILITY_PLATFORM_AX_PLATFORM_NODE_DELEGATE_H_

7	7

8 #include "ui/accessibility/ax_enums.h"	8 #include "ui/accessibility/ax_enums.h"

9 #include "ui/accessibility/ax_export.h"	9 #include "ui/accessibility/ax_export.h"

10 #include "ui/gfx/geometry/vector2d.h"	10 #include "ui/gfx/geometry/vector2d.h"

(...skipping 63 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
74 //	74 //

75	75

76 // Return the platform-native GUI object that should be used as a target	76 // Return the platform-native GUI object that should be used as a target

77 // for accessibility events.	77 // for accessibility events.

78 virtual gfx::AcceleratedWidget GetTargetForNativeAccessibilityEvent() = 0;	78 virtual gfx::AcceleratedWidget GetTargetForNativeAccessibilityEvent() = 0;

79	79

80 //	80 //

81 // Actions.	81 // Actions.

82 //	82 //

83	83

84 // Calls one of the methods below to perform an accessibility action,	84 // Calls one of the methods below to perform an accessibility action,
	tapted 2017/04/03 23:28:22 nit: comment out of date (no more "methods below" nit: comment out of date (no more "methods below" :) dmazzoni 2017/04/03 23:55:16 Done. Show quoted text On 2017/04/03 23:28:22, tapted wrote: > nit: comment out of date (no more "methods below" :) Done.
85 // switching on the ui::AXAction provided in \|data\|.	85 // switching on the ui::AXAction provided in \|data\|.

86 virtual bool AccessibilityPerformAction(const ui::AXActionData& data) = 0;	86 virtual bool AccessibilityPerformAction(const ui::AXActionData& data) = 0;

87

88 // Perform the default action, e.g. click a button, follow a link, or

89 // toggle a checkbox.

90 virtual void DoDefaultAction() = 0;
tapted 2017/04/03 23:28:23 test_ax_node_wrapper.h still has one of these by t test_ax_node_wrapper.h still has one of these by the look of the trybots dmazzoni 2017/04/03 23:55:16 Done. Show quoted text On 2017/04/03 23:28:23, tapted wrote: > test_ax_node_wrapper.h still has one of these by the look of the trybots Done.
91 };	87 };

92	88

93 } // namespace ui	89 } // namespace ui

94	90

95 #endif // UI_ACCESSIBILITY_PLATFORM_AX_PLATFORM_NODE_DELEGATE_H_	91 #endif // UI_ACCESSIBILITY_PLATFORM_AX_PLATFORM_NODE_DELEGATE_H_

OLD	NEW