Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 279583002: Fix instructions to generate .DEPS.git (Closed)

Created:
6 years, 7 months ago by Primiano Tucci (use gerrit)
Modified:
6 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Fix instructions to generate .DEPS.git Adds the -w argument in the instructions in DEPS. See chromium-dev thread http://goo.gl/sVP94W. BUG= NOTRY=true TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269435

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M DEPS View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Primiano Tucci (use gerrit)
6 years, 7 months ago (2014-05-08 21:24:02 UTC) #1
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 7 months ago (2014-05-08 21:27:04 UTC) #2
Primiano Tucci (use gerrit)
6 years, 7 months ago (2014-05-08 21:27:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/279583002/1
6 years, 7 months ago (2014-05-08 21:30:33 UTC) #4
brettw
lgtm https://codereview.chromium.org/279583002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/279583002/diff/1/DEPS#newcode7 DEPS:7: # python tools/deps2git/deps2git.py -o .DEPS.git -w /path/chrome # ...
6 years, 7 months ago (2014-05-08 21:41:01 UTC) #5
Primiano Tucci (use gerrit)
The CQ bit was unchecked by primiano@chromium.org
6 years, 7 months ago (2014-05-08 21:47:35 UTC) #6
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 7 months ago (2014-05-08 21:51:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/279583002/20001
6 years, 7 months ago (2014-05-08 21:53:17 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 22:19:31 UTC) #9
Message was sent while issue was closed.
Change committed as 269435

Powered by Google App Engine
This is Rietveld 408576698