third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py - Issue 2795793003: Make run-webkit-tests work with virtual parent LayoutTest directories

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

Issue 2795793003: Make run-webkit-tests work with virtual parent LayoutTest directories (Closed)

Patch Set: fix test for win_chromium_rel_ng Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

index 73616d9f98d9fd018b8effd5e6da73b6a49e7b7b..d27d3f15d33f44b9cea397bb901693b6ea04b68f 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

@@ -446,9 +446,15 @@ class PortTest(unittest.TestCase):

self.assertIn('passes/virtual_passes/test-virtual-passes.html', tests)

self.assertNotIn('virtual/virtual_passes/passes/text.html', tests)

+ tests = port.tests(['virtual/virtual_passes/'])

+ self.assertIn('virtual/virtual_passes/passes/test-virtual-passes.html', tests)

+ self.assertIn('virtual/virtual_passes/passes_two/test-virtual-passes.html', tests)

tests = port.tests(['virtual/virtual_passes/passes'])

self.assertNotIn('passes/text.html', tests)

self.assertIn('virtual/virtual_passes/passes/test-virtual-passes.html', tests)

+ self.assertNotIn('virtual/virtual_passes/passes_two/test-virtual-passes.html', tests)

self.assertNotIn('passes/test-virtual-passes.html', tests)

self.assertNotIn('virtual/virtual_passes/passes/test-virtual-virtual/passes.html', tests)

self.assertNotIn('virtual/virtual_passes/passes/virtual_passes/passes/test-virtual-passes.html', tests)