third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp - Issue 2795783004: Move core MediaControls implementation to modules/media_controls/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp

Issue 2795783004: Move core MediaControls implementation to modules/media_controls/. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.h ('k') | third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp

index 070f17b32971c62841984ede8a0b15d1d8086e8d..19a7ecec16d7ee6f7bd9d6c74393d4e69127a33b 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp

@@ -6,7 +6,7 @@

#include "core/events/Event.h"

#include "core/html/HTMLMediaElement.h"

-#include "core/html/shadow/MediaControls.h"

+#include "core/html/media/MediaControls.h"

#include "core/html/track/TextTrackList.h"

namespace blink {

@@ -34,8 +34,8 @@ void MediaControlsMediaEventListener::attach() {

// old APIs are handled.

mediaElement().addEventListener(EventTypeNames::webkitfullscreenchange, this,

false);

- m_mediaControls->document().addEventListener(EventTypeNames::fullscreenchange,

- this, false);

+ m_mediaControls->ownerDocument().addEventListener(

+ EventTypeNames::fullscreenchange, this, false);

// TextTracks events.

TextTrackList* textTracks = mediaElement().textTracks();

@@ -47,7 +47,7 @@ void MediaControlsMediaEventListener::attach() {

void MediaControlsMediaEventListener::detach() {

DCHECK(!mediaElement().isConnected());

- m_mediaControls->document().removeEventListener(

+ m_mediaControls->ownerDocument().removeEventListener(

EventTypeNames::fullscreenchange, this, false);

TextTrackList* textTracks = mediaElement().textTracks();