third_party/WebKit/Source/core/html/media/HTMLMediaElementControlsList.h - Issue 2795783004: Move core MediaControls implementation to modules/media_controls/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/media/HTMLMediaElementControlsList.h

Issue 2795783004: Move core MediaControls implementation to modules/media_controls/. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp ('k') | third_party/WebKit/Source/core/html/media/MediaControls.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/media/HTMLMediaElementControlsList.h

diff --git a/third_party/WebKit/Source/core/html/media/HTMLMediaElementControlsList.h b/third_party/WebKit/Source/core/html/media/HTMLMediaElementControlsList.h

index 8b4d0d613525161c7489fd61231d2e5c6b5b106d..e638b3586c5d5ad3298246f6e123d40aa10c5e18 100644

--- a/third_party/WebKit/Source/core/html/media/HTMLMediaElementControlsList.h

+++ b/third_party/WebKit/Source/core/html/media/HTMLMediaElementControlsList.h

@@ -5,6 +5,7 @@

#ifndef HTMLMediaElementControlsList_h

#define HTMLMediaElementControlsList_h

+#include "core/CoreExport.h"

#include "core/dom/DOMTokenList.h"

#include "platform/heap/Handle.h"

@@ -26,9 +27,9 @@ class HTMLMediaElementControlsList final : public DOMTokenList,

DECLARE_VIRTUAL_TRACE();

// Whether the list dictates to hide a certain control.

- bool shouldHideDownload() const;

- bool shouldHideFullscreen() const;

- bool shouldHideRemotePlayback() const;

+ CORE_EXPORT bool shouldHideDownload() const;

+ CORE_EXPORT bool shouldHideFullscreen() const;

+ CORE_EXPORT bool shouldHideRemotePlayback() const;

private:

explicit HTMLMediaElementControlsList(HTMLMediaElement*);