Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

Issue 2795763003: MD Settings: adjust dialog style and scroll border visual (Closed)
Patch Set: explicitly assert intersection entries max length Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
diff --git a/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html b/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
index 14a5a866e2d4e464289772fb38d5256ff0eed063..e0edb3424b55c3b8d7810adf1d1b812f870811fd 100644
--- a/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
+++ b/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
@@ -30,9 +30,8 @@
.top-container {
align-items: center;
- border-bottom: 1px solid var(--divider-color);
display: flex;
- min-height: 52px;
+ min-height: 47px;
}
.title-container {
@@ -42,15 +41,23 @@
}
:host ::content .title {
- font-size: 123.07%; /* (16px / 13px) * 100 */
+ font-size: 115.38%; /* (15px / 13px) * 100 */
+ line-height: 1;
+ margin-bottom: 16px;
+ margin-top: 16px;
dschuyler 2017/04/06 22:29:13 nit: margin: 16px 0; can replace lines 46 and 47.
scottchen 2017/04/06 22:36:01 Done.
}
#close {
--paper-icon-button: {
- height: 40px;
- width: 40px;
+ height: 36px;
+ width: 36px;
};
- -webkit-margin-end: 6px;
+
+ --layout-inline: {
+ display: flex;
+ };
+
+ -webkit-margin-end: 4px;
/* <paper-icon-button> overrides --iron-icon-{height,width}, so this
* padding essentially reduces 40x40 to 20x20. */
padding: 10px;
@@ -66,12 +73,17 @@
:host([show-scroll-borders]) .body-container {
/* Prevent layout moving when border does appear. */
border-bottom: 1px solid transparent;
+ border-top: 1px solid transparent;
}
:host([show-scroll-borders]) .body-container.bottom-scrollable {
border-bottom: 1px solid var(--paper-grey-300);
}
+ :host([show-scroll-borders]) .body-container.top-scrollable {
+ border-top: 1px solid var(--paper-grey-300);
+ }
+
:host ::content .body {
padding-bottom: 12px;
padding-top: 12px;
@@ -79,18 +91,16 @@
:host ::content .body,
:host ::content .title {
- -webkit-padding-end: 24px;
- -webkit-padding-start: 24px;
+ padding: 0 16px;
flex: 1;
}
:host ::content .button-container {
- -webkit-padding-end: 16px;
- -webkit-padding-start: 16px;
+ padding: 0 16px;
display: flex;
justify-content: flex-end;
- margin-bottom: 12px;
- margin-top: 12px;
+ margin-bottom: 16px;
+ margin-top: 16px;
dschuyler 2017/04/06 22:29:13 margin: 16px 0;
scottchen 2017/04/06 22:36:01 Done.
}
:host ::content .button-container .cancel-button {
@@ -118,6 +128,7 @@
</paper-icon-button>
</div>
<div class="body-container">
+ <span id="bodyTopMarker"></span>
<content select=".body"></content>
<span id="bodyBottomMarker"></span>
</div>
« no previous file with comments | « chrome/test/data/webui/cr_elements/cr_dialog_test.js ('k') | ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698