MD Settings: adjust dialog style and scroll border visual

chrome/test/data/webui/cr_elements/cr_dialog_test.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 suite('cr-dialog', function() {
   setup(function() {
     PolymerTest.clearBody();
   });
 
   test('focuses title on show', function() {
@@ skipping 102 matching lines @@
     document.body.innerHTML = `
       <dialog is="cr-dialog" show-scroll-borders>
         <div class="title">title</div>
         <div class="body">body</div>
       </dialog>`;
 
     var dialog = document.body.querySelector('dialog');
     var bodyContainer = dialog.$$('.body-container');
     assertTrue(!!bodyContainer);
 
+    dialog.showModal();  // Attach the dialog for the first time here.
+
     var observerCount = 0;
 
     // Needs to setup the observer before attaching, since InteractionObserver
     // calls callback before MutationObserver does.
-    var observer = new MutationObserver(function() {
+    var observer = new MutationObserver(function(changes) {
+      if (changes[0].attributeName !=
+          'class')  // Only care about class mutations

[dpapad, 2017/04/05 23:56:10]

Formatting seems a bit off here. Can we move the comment to a separate line and
keep the condition to a single line?

[scottchen, 2017/04/06 01:11:13]

Done.

+        return;
+
       observerCount++;
       if (observerCount == 1) {  // Triggered when scrolled to bottom.
+        console.log(bodyContainer.classList[0]);

[dpapad, 2017/04/05 23:56:10]

Remove console.log.

[scottchen, 2017/04/06 01:11:13]

Done.

         assertFalse(bodyContainer.classList.contains('bottom-scrollable'));
+        assertTrue(bodyContainer.classList.contains('top-scrollable'));
         bodyContainer.scrollTop = 0;
       } else if (observerCount == 2) {  // Triggered when scrolled back to top.

[dpapad, 2017/04/05 23:56:10]

Is there a way to test the case where both top and bottom borders are showing?

         assertTrue(bodyContainer.classList.contains('bottom-scrollable'));
+        assertFalse(bodyContainer.classList.contains('top-scrollable'));
         observer.disconnect();
         done();
       }
     });
     observer.observe(bodyContainer, {attributes: true});
 
     // Height is normally set via CSS, but mixin doesn't work with innerHTML.
     bodyContainer.style.height = '1px';
     bodyContainer.scrollTop = 100;
-    dialog.showModal();  // Attach the dialog for the first time here.
   });
 });