Issue 2795743003: Enable high latency audio on Android N+ for basic playback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2795743003: Enable high latency audio on Android N+ for basic playback.

Created:
3 years, 8 months ago by DaleCurtis

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org, mlamouri+watch-media_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Enable high latency audio on Android N+ for basic playback. Per discussions with Android Audio team this should allow for lower power consumption during basic playback. This is supposedly in the N NDK, but I can't find it, so waiting to hear back from the Android audio folks. It's in the master AOSP branch though... < todo: power tests > BUG=tbd TEST=playback seems fine?? CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -6 lines)			Patch
M	media/audio/android/audio_manager_android.cc	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	media/audio/android/opensles_output.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	media/audio/android/opensles_output.cc	View	5 chunks	+41 lines, -4 lines	0 comments	Download
M	media/audio/audio_manager_base.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

DaleCurtis

3 years, 8 months ago (2017-04-04 00:38:59 UTC) #1

Description was changed from

==========
Enable high latency audio on Android N+ for basic playback.

Per discussions with Android Audio team this should allow for lower
power consumption during basic playback. This is supposedly in the
N NDK, but I can't find it, so waiting to hear back from the Android
audio folks. It's in the master AOSP branch though...

< todo: power tests >

BUG=tbd
TEST=playback seems fine??
==========

to

==========
Enable high latency audio on Android N+ for basic playback.

Per discussions with Android Audio team this should allow for lower
power consumption during basic playback. This is supposedly in the
N NDK, but I can't find it, so waiting to hear back from the Android
audio folks. It's in the master AOSP branch though...

< todo: power tests >

BUG=tbd
TEST=playback seems fine??
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages