Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2795743002: Add context information to driver and add hooks for plugin management (Closed)

Created:
3 years, 8 months ago by Brian Wilkerson
Modified:
3 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add context information to driver and add hooks for plugin management R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/dd49e79f744e0915eb163ae478bfe9d477af4d2e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -80 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 7 chunks +35 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 13 chunks +39 lines, -30 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/plugin_manager.dart View 9 chunks +13 lines, -9 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/plugin_watcher.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart View 2 chunks +13 lines, -13 lines 0 comments Download
M pkg/analysis_server/test/abstract_context.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 3 chunks +6 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/search/search_engine2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/src/plugin/plugin_manager_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/test/src/plugin/plugin_watcher_test.dart View 2 chunks +1 line, -1 line 0 comments Download
A pkg/analyzer/lib/context/context_root.dart View 1 chunk +68 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/context/builder.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 13 chunks +62 lines, -8 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test_case.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/analysis/base.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/strong_test_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/incremental_resolved_ast_generator_impl.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 8 months ago (2017-04-03 16:45:14 UTC) #2
scheglov
lgtm
3 years, 8 months ago (2017-04-03 17:02:16 UTC) #3
Brian Wilkerson
3 years, 8 months ago (2017-04-03 17:13:51 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
dd49e79f744e0915eb163ae478bfe9d477af4d2e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698