Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2795723003: Change signature of resolveConstructors. (Closed)

Created:
3 years, 8 months ago by ahe
Modified:
3 years, 8 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M pkg/front_end/lib/src/fasta/builder/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/builder/class_builder.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ahe
Something is odd on the buildbot. But the signature of resolveConstructors is also odd. So ...
3 years, 8 months ago (2017-04-04 15:15:08 UTC) #3
ahe
TBR
3 years, 8 months ago (2017-04-04 15:15:21 UTC) #4
ahe
Committed patchset #1 (id:20001) manually as 79b021be927a16202dc1f5834f7128dd34fe6539 (presubmit successful).
3 years, 8 months ago (2017-04-04 15:15:38 UTC) #6
Paul Berry
3 years, 8 months ago (2017-04-04 16:42:55 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698