ui: Add debug flag to show composited layer borders in ChromeOS UI.

ui/compositor/compositor.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/compositor/compositor.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <deque>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/stl_util.h"
+#include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/sys_info.h"
 #include "base/trace_event/trace_event.h"
 #include "build/build_config.h"
 #include "cc/animation/animation_host.h"
 #include "cc/animation/animation_id_provider.h"
 #include "cc/animation/animation_timeline.h"
 #include "cc/base/switches.h"
 #include "cc/input/input_handler.h"
 #include "cc/layers/layer.h"
@@ skipping 73 matching lines @@
 #if defined(OS_WIN)
   settings.renderer_settings.finish_rendering_on_resize = true;
 #elif defined(OS_MACOSX)
   settings.renderer_settings.release_overlay_resources_after_gpu_query = true;
 #endif
   settings.renderer_settings.gl_composited_texture_quad_border =
       command_line->HasSwitch(cc::switches::kGlCompositedTextureQuadBorder);
   settings.renderer_settings.show_overdraw_feedback =
       command_line->HasSwitch(cc::switches::kShowOverdrawFeedback);
 
-  // These flags should be mirrored by renderer versions in content/renderer/.
-  settings.initial_debug_state.show_debug_borders =
-      command_line->HasSwitch(cc::switches::kUIShowCompositedLayerBorders);
+  if (command_line->HasSwitch(cc::switches::kUIShowCompositedLayerBorders)) {

[danakj, 2017/04/13 15:25:51]

I'd like --ui-show-composited-layer-borders (with no =stuff) to do the same
thing as before, ie empty string means all. This makes the about:flags stuff a
bit simpler and harder to mess up if we add new ones, as we don't have to list
everything in the all case.

[reveman, 2017/04/13 17:00:46]

Done.

+    std::string layer_borders_string = command_line->GetSwitchValueASCII(
+        cc::switches::kUIShowCompositedLayerBorders);
+    std::vector<std::string> entries = base::SplitString(
+        layer_borders_string, ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
+    for (const auto& entry : entries) {
+      const struct {
+        const char* name;
+        cc::DebugBorderType type;
+      } kBorders[] = {{"renderpass", cc::DebugBorderType::RENDERPASS},
+                      {"surface", cc::DebugBorderType::SURFACE},
+                      {"layer", cc::DebugBorderType::LAYER}};
+      for (const auto& border : kBorders) {
+        if (border.name == entry) {
+          settings.initial_debug_state.show_debug_borders.set(border.type);
+          break;
+        }
+      }
+    }
+  }
   settings.initial_debug_state.show_fps_counter =
       command_line->HasSwitch(cc::switches::kUIShowFPSCounter);
   settings.initial_debug_state.show_layer_animation_bounds_rects =
       command_line->HasSwitch(cc::switches::kUIShowLayerAnimationBounds);
   settings.initial_debug_state.show_paint_rects =
       command_line->HasSwitch(switches::kUIShowPaintRects);
   settings.initial_debug_state.show_property_changed_rects =
       command_line->HasSwitch(cc::switches::kUIShowPropertyChangedRects);
   settings.initial_debug_state.show_surface_damage_rects =
       command_line->HasSwitch(cc::switches::kUIShowSurfaceDamageRects);
@@ skipping 446 matching lines @@
 void Compositor::TimeoutLocks() {
   // Make a copy, we're going to cause |active_locks_| to become
   // empty.
   std::vector<CompositorLock*> locks = active_locks_;
   for (auto* lock : locks)
     lock->TimeoutLock();
   DCHECK(active_locks_.empty());
 }
 
 }  // namespace ui