ui: Add debug flag to show composited layer borders in ChromeOS UI.

chrome/browser/about_flags.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/about_flags.h"
 
 #include <iterator>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 418 matching lines @@
 const FeatureEntry::Choice kDataSaverPromptChoices[] = {
     {flags_ui::kGenericExperimentChoiceDefault, "", ""},
     {flags_ui::kGenericExperimentChoiceEnabled,
      chromeos::switches::kEnableDataSaverPrompt, ""},
     {flags_ui::kGenericExperimentChoiceDisabled,
      chromeos::switches::kDisableDataSaverPrompt, ""},
     {flag_descriptions::kDatasaverPromptDemoMode,
      chromeos::switches::kEnableDataSaverPrompt,
      chromeos::switches::kDataSaverPromptDemoMode},
 };
+
+const FeatureEntry::Choice kUiShowCompositedLayerBordersChoices[] = {
+    {flags_ui::kGenericExperimentChoiceDefault, "", ""},
+    {flag_descriptions::kUiShowCompositedLayerBordersRenderpass,
+     cc::switches::kUIShowCompositedLayerBorders, "renderpass"},

[danakj, 2017/04/13 15:25:51]

should we introduce constants for these parameters? (maybe not for the all ""
case tho)

[reveman, 2017/04/13 17:00:46]

Done.

+    {flag_descriptions::kUiShowCompositedLayerBordersSurface,
+     cc::switches::kUIShowCompositedLayerBorders, "surface"},
+    {flag_descriptions::kUiShowCompositedLayerBordersLayer,
+     cc::switches::kUIShowCompositedLayerBorders, "layer"},
+    {flag_descriptions::kUiShowCompositedLayerBordersAll,
+     cc::switches::kUIShowCompositedLayerBorders, "renderpass,surface,layer"}};

[danakj, 2017/04/13 15:25:51]

maybe just make this "" and empty => all?

[reveman, 2017/04/13 17:00:46]

Done.

 #endif  // OS_CHROMEOS
 
 const FeatureEntry::Choice kV8CacheOptionsChoices[] = {
     {flags_ui::kGenericExperimentChoiceDefault, "", ""},
     {flags_ui::kGenericExperimentChoiceDisabled, switches::kV8CacheOptions,
      "none"},
     {flag_descriptions::kV8CacheOptionsParse, switches::kV8CacheOptions,
      "parse"},
     {flag_descriptions::kV8CacheOptionsCode, switches::kV8CacheOptions, "code"},
 };
@@ skipping 711 matching lines @@
      MULTI_VALUE_TYPE(kAshShelfColorSchemeChoices)},
 #endif  // USE_ASH
 #if defined(OS_CHROMEOS)
     {"material-design-ink-drop-animation-speed",
      flag_descriptions::kMaterialDesignInkDropAnimationSpeedName,
      flag_descriptions::kMaterialDesignInkDropAnimationSpeedDescription,
      kOsCrOS, MULTI_VALUE_TYPE(kAshMaterialDesignInkDropAnimationSpeed)},
     {"ui-slow-animations", flag_descriptions::kUiSlowAnimationsName,
      flag_descriptions::kUiSlowAnimationsDescription, kOsCrOS,
      SINGLE_VALUE_TYPE(switches::kUISlowAnimations)},
+    {"ui-show-composited-layer-borders",
+     flag_descriptions::kUiShowCompositedLayerBordersName,
+     flag_descriptions::kUiShowCompositedLayerBordersDescription, kOsCrOS,
+     MULTI_VALUE_TYPE(kUiShowCompositedLayerBordersChoices)},
     {"disable-cloud-import", flag_descriptions::kCloudImport,
      flag_descriptions::kCloudImportDescription, kOsCrOS,
      SINGLE_DISABLE_VALUE_TYPE(chromeos::switches::kDisableCloudImport)},
     {"enable-request-tablet-site", flag_descriptions::kRequestTabletSiteName,
      flag_descriptions::kRequestTabletSiteDescription, kOsCrOS,
      SINGLE_VALUE_TYPE(chromeos::switches::kEnableRequestTabletSite)},
 #endif  // OS_CHROMEOS
     {"debug-packed-apps", flag_descriptions::kDebugPackedAppName,
      flag_descriptions::kDebugPackedAppDescription, kOsDesktop,
      SINGLE_VALUE_TYPE(switches::kDebugPackedApps)},
@@ skipping 1541 matching lines @@
 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
 
 const FeatureEntry* GetFeatureEntries(size_t* count) {
   *count = arraysize(kFeatureEntries);
   return kFeatureEntries;
 }
 
 }  // namespace testing
 
 }  // namespace about_flags