Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1531)

Unified Diff: cc/surfaces/surface_unittest.cc

Issue 2795683003: [cc]Replace use of SurfaceFactory with CompositorFrameSinkSupport in tests (Closed)
Patch Set: Update returned_resources_ in FakeCompositorFrameSinkSupportClient::DidReceiveCompositorFrameAck Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/surface_manager_ref_unittest.cc ('k') | cc/surfaces/surfaces_pixeltest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_unittest.cc
diff --git a/cc/surfaces/surface_unittest.cc b/cc/surfaces/surface_unittest.cc
index c20f313d9cb3d80ce8c2da054ef9e5271b24f0b4..e40cc05f9b335752a512155b841d7857608cda07 100644
--- a/cc/surfaces/surface_unittest.cc
+++ b/cc/surfaces/surface_unittest.cc
@@ -5,10 +5,9 @@
#include "cc/surfaces/surface.h"
#include "base/memory/ptr_util.h"
#include "cc/output/copy_output_result.h"
+#include "cc/surfaces/compositor_frame_sink_support.h"
#include "cc/surfaces/local_surface_id_allocator.h"
#include "cc/surfaces/surface_dependency_tracker.h"
-#include "cc/surfaces/surface_factory.h"
-#include "cc/surfaces/surface_factory_client.h"
#include "cc/surfaces/surface_manager.h"
#include "cc/test/begin_frame_args_test.h"
#include "cc/test/fake_external_begin_frame_source.h"
@@ -19,36 +18,23 @@
namespace cc {
namespace {
-static constexpr FrameSinkId kArbitraryFrameSinkId(1, 1);
-
-class FakeSurfaceFactoryClient : public SurfaceFactoryClient {
- public:
- FakeSurfaceFactoryClient() : begin_frame_source_(nullptr) {}
-
- void ReturnResources(const ReturnedResourceArray& resources) override {}
-
- void SetBeginFrameSource(BeginFrameSource* begin_frame_source) override {
- begin_frame_source_ = begin_frame_source;
- }
-
- BeginFrameSource* begin_frame_source() { return begin_frame_source_; }
-
- private:
- BeginFrameSource* begin_frame_source_;
-};
+constexpr FrameSinkId kArbitraryFrameSinkId(1, 1);
+constexpr bool kIsRoot = true;
+constexpr bool kHandlesFrameSinkIdInvalidation = true;
+constexpr bool kNeedsSyncPoints = true;
TEST(SurfaceTest, SurfaceLifetime) {
SurfaceManager manager;
- FakeSurfaceFactoryClient surface_factory_client;
- SurfaceFactory factory(kArbitraryFrameSinkId, &manager,
- &surface_factory_client);
+ std::unique_ptr<CompositorFrameSinkSupport> support =
+ CompositorFrameSinkSupport::Create(
+ nullptr, &manager, kArbitraryFrameSinkId, kIsRoot,
+ kHandlesFrameSinkIdInvalidation, kNeedsSyncPoints);
LocalSurfaceId local_surface_id(6, base::UnguessableToken::Create());
SurfaceId surface_id(kArbitraryFrameSinkId, local_surface_id);
- factory.SubmitCompositorFrame(local_surface_id, CompositorFrame(),
- SurfaceFactory::DrawCallback());
+ support->SubmitCompositorFrame(local_surface_id, CompositorFrame());
EXPECT_TRUE(manager.GetSurfaceForId(surface_id));
- factory.EvictSurface();
+ support->EvictFrame();
EXPECT_EQ(NULL, manager.GetSurfaceForId(surface_id));
}
@@ -71,21 +57,21 @@ void TestCopyResultCallback(bool* called,
// aggregated on the next frame.
TEST(SurfaceTest, CopyRequestLifetime) {
SurfaceManager manager;
- FakeSurfaceFactoryClient surface_factory_client;
- SurfaceFactory factory(kArbitraryFrameSinkId, &manager,
- &surface_factory_client);
+ std::unique_ptr<CompositorFrameSinkSupport> support =
+ CompositorFrameSinkSupport::Create(
+ nullptr, &manager, kArbitraryFrameSinkId, kIsRoot,
+ kHandlesFrameSinkIdInvalidation, kNeedsSyncPoints);
LocalSurfaceId local_surface_id(6, base::UnguessableToken::Create());
SurfaceId surface_id(kArbitraryFrameSinkId, local_surface_id);
CompositorFrame frame;
frame.render_pass_list.push_back(RenderPass::Create());
- factory.SubmitCompositorFrame(local_surface_id, std::move(frame),
- SurfaceFactory::DrawCallback());
+ support->SubmitCompositorFrame(local_surface_id, std::move(frame));
Surface* surface = manager.GetSurfaceForId(surface_id);
ASSERT_TRUE(!!surface);
bool copy_called = false;
- factory.RequestCopyOfSurface(CopyOutputRequest::CreateRequest(
+ support->RequestCopyOfSurface(CopyOutputRequest::CreateRequest(
base::Bind(&TestCopyResultCallback, &copy_called)));
EXPECT_TRUE(manager.GetSurfaceForId(surface_id));
EXPECT_FALSE(copy_called);
@@ -99,8 +85,7 @@ TEST(SurfaceTest, CopyRequestLifetime) {
frame.render_pass_list.back()->id = i * 3 + start_id + 1;
frame.render_pass_list.push_back(RenderPass::Create());
frame.render_pass_list.back()->id = i * 3 + start_id + 2;
- factory.SubmitCompositorFrame(local_surface_id, std::move(frame),
- SurfaceFactory::DrawCallback());
+ support->SubmitCompositorFrame(local_surface_id, std::move(frame));
}
int last_pass_id = (max_frame - 1) * 3 + start_id + 2;
@@ -120,7 +105,7 @@ TEST(SurfaceTest, CopyRequestLifetime) {
copy_requests.find(last_pass_id)->second->SendEmptyResult();
EXPECT_TRUE(copy_called);
- factory.EvictSurface();
+ support->EvictFrame();
}
} // namespace
« no previous file with comments | « cc/surfaces/surface_manager_ref_unittest.cc ('k') | cc/surfaces/surfaces_pixeltest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698