[cc]Replace use of SurfaceFactory with CompositorFrameSinkSupport in tests

cc/test/empty_compositor_frame_sink_support_client.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CC_TEST_EMPTY_COMPOSITOR_FRAME_SINK_SUPPORT_CLIENT_H_
+#define CC_TEST_EMPTY_COMPOSITOR_FRAME_SINK_SUPPORT_CLIENT_H_
+
+#include "cc/surfaces/compositor_frame_sink_support_client.h"
+#include "cc/surfaces/local_surface_id.h"
+#include "ui/gfx/geometry/rect.h"
+
+namespace cc {
+
+class EmptyCompositorFrameSinkSupportClient

[danakj, 2017/04/07 15:52:45]

I know you're copying this name from where it came from but
a) I don't think Empty describes this class well
b) The bar for a class up in cc/test/ is a bit higher than for a class defined
in a test file for a single test
c) Our pattern here is to make a cc/test/ class named FakeFooBar when it is a
FooBar that provides knobs for tests to change behaviour or peek at states.

So, FakeCompositorFrameSinkSupportClient?

In general, our naming scheme tries to follow the somewhat standard "Stub"
(empty interface impl), "Mock" (used to verify usage with gmock), "Fake" (a
lightweight impl for testing). This describes much more detail:
https://www.martinfowler.com/articles/mocksArentStubs.html

[Alex Z., 2017/04/07 20:43:58]

Done.

+    : public CompositorFrameSinkSupportClient {
+ public:
+  EmptyCompositorFrameSinkSupportClient();
+  ~EmptyCompositorFrameSinkSupportClient() override;
+
+  // CompositorFrameSinkSupportClient implementation.
+  void DidReceiveCompositorFrameAck() override;
+  void OnBeginFrame(const BeginFrameArgs& args) override;
+  void ReclaimResources(const ReturnedResourceArray& resources) override;
+  void WillDrawSurface(const LocalSurfaceId& local_surface_id,
+                       const gfx::Rect& damage_rect) override;
+
+  const gfx::Rect& last_damage_rect() const { return last_damage_rect_; }
+  const LocalSurfaceId& last_local_surface_id() const {
+    return last_local_surface_id_;
+  }
+  const ReturnedResourceArray& returned_resources() const {
+    return returned_resources_;
+  }
+
+ private:
+  gfx::Rect last_damage_rect_;
+  LocalSurfaceId last_local_surface_id_;
+  ReturnedResourceArray returned_resources_;
+
+  DISALLOW_COPY_AND_ASSIGN(EmptyCompositorFrameSinkSupportClient);
+};
+
+}  // namespace cc
+
+#endif  // CC_TEST_EMPTY_COMPOSITOR_FRAME_SINK_SUPPORT_CLIENT_H_