[cc]Replace use of SurfaceFactory with CompositorFrameSinkSupport in tests

cc/surfaces/surface_hittest_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "cc/output/compositor_frame.h"
+#include "cc/surfaces/compositor_frame_sink_support.h"
 #include "cc/surfaces/local_surface_id_allocator.h"
 #include "cc/surfaces/surface.h"
-#include "cc/surfaces/surface_factory.h"
-#include "cc/surfaces/surface_factory_client.h"
 #include "cc/surfaces/surface_hittest.h"
 #include "cc/surfaces/surface_manager.h"
 #include "cc/test/surface_hittest_test_helpers.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/gfx/geometry/size.h"
 
 namespace cc {
 
 namespace {
 
-static constexpr FrameSinkId kArbitraryFrameSinkId(1, 1);
+constexpr FrameSinkId kArbitraryFrameSinkId(1, 1);
+constexpr bool is_root = true;
+constexpr bool is_root_child = false;
+constexpr bool handles_frame_sink_id_invalidation = true;
+constexpr bool needs_sync_points = true;

[Fady Samuel, 2017/04/06 12:17:22]

Ohh just noticed. These are all constants so I think the style guide says
kConstantNaming:
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md

[Alex Z., 2017/04/06 12:34:32]

Done.

 
 struct TestCase {
   SurfaceId input_surface_id;
   gfx::Point input_point;
   SurfaceId expected_compositor_frame_sink_id;
   gfx::Point expected_output_point;
 };
 
 void RunTests(SurfaceHittestDelegate* delegate,
               SurfaceManager* manager,
@@ skipping 21 matching lines @@
 }
 
 }  // namespace
 
 using namespace test;
 
 // This test verifies that hit testing on a surface that does not exist does
 // not crash.
 TEST(SurfaceHittestTest, Hittest_BadCompositorFrameDoesNotCrash) {
   SurfaceManager manager;
-  EmptySurfaceFactoryClient client;
   FrameSinkId root_frame_sink_id(kArbitraryFrameSinkId);
-  SurfaceFactory root_factory(root_frame_sink_id, &manager, &client);
+  CompositorFrameSinkSupport root_support(
+      nullptr, &manager, kArbitraryFrameSinkId, is_root,
+      handles_frame_sink_id_invalidation, needs_sync_points);
 
   // Creates a root surface.
   gfx::Rect root_rect(300, 300);
   RenderPass* root_pass = nullptr;
   CompositorFrame root_frame = CreateCompositorFrame(root_rect, &root_pass);
 
   // Add a reference to a non-existant child surface on the root surface.
   SurfaceId child_surface_id(
       kArbitraryFrameSinkId,
       LocalSurfaceId(0xdeadbeef, base::UnguessableToken::Create()));
   gfx::Rect child_rect(200, 200);
   CreateSurfaceDrawQuad(root_pass,
                         gfx::Transform(),
                         root_rect,
                         child_rect,
                         child_surface_id);
 
   // Submit the root frame.
   LocalSurfaceIdAllocator root_allocator;
   LocalSurfaceId root_local_surface_id = root_allocator.GenerateId();
   SurfaceId root_surface_id(root_frame_sink_id, root_local_surface_id);
-  root_factory.SubmitCompositorFrame(root_local_surface_id,
-                                     std::move(root_frame),
-                                     SurfaceFactory::DrawCallback());
+  root_support.SubmitCompositorFrame(root_local_surface_id,
+                                     std::move(root_frame));
 
   {
     SurfaceHittest hittest(nullptr, &manager);
     // It is expected this test will complete without crashes.
     gfx::Transform transform;
     EXPECT_EQ(root_surface_id,
               hittest.GetTargetSurfaceAtPoint(
                   root_surface_id, gfx::Point(100, 100), &transform));
   }
 
-  root_factory.EvictSurface();
+  root_support.EvictFrame();
 }
 
 TEST(SurfaceHittestTest, Hittest_SingleSurface) {
   SurfaceManager manager;
 
   // Set up root FrameSink.
-  EmptySurfaceFactoryClient root_client;
   FrameSinkId root_frame_sink_id(1, 1);
-  SurfaceFactory root_factory(root_frame_sink_id, &manager, &root_client);
+  CompositorFrameSinkSupport root_support(
+      nullptr, &manager, root_frame_sink_id, is_root,
+      handles_frame_sink_id_invalidation, needs_sync_points);
 
   // Creates a root surface.
   gfx::Rect root_rect(300, 300);
   RenderPass* root_pass = nullptr;
   CompositorFrame root_frame = CreateCompositorFrame(root_rect, &root_pass);
 
   // Submit the root frame.
   LocalSurfaceIdAllocator root_allocator;
   LocalSurfaceId root_local_surface_id = root_allocator.GenerateId();
   SurfaceId root_surface_id(root_frame_sink_id, root_local_surface_id);
-  root_factory.SubmitCompositorFrame(root_local_surface_id,
-                                     std::move(root_frame),
-                                     SurfaceFactory::DrawCallback());
+  root_support.SubmitCompositorFrame(root_local_surface_id,
+                                     std::move(root_frame));
   TestCase tests[] = {
     {
       root_surface_id,
       gfx::Point(100, 100),
       root_surface_id,
       gfx::Point(100, 100)
     },
   };
 
   RunTests(nullptr, &manager, tests, arraysize(tests));
 
-  root_factory.EvictSurface();
+  root_support.EvictFrame();
 }
 
 TEST(SurfaceHittestTest, Hittest_ChildSurface) {
   SurfaceManager manager;
 
   // Set up root FrameSink.
-  EmptySurfaceFactoryClient root_client;
   FrameSinkId root_frame_sink_id(1, 1);
-  SurfaceFactory root_factory(root_frame_sink_id, &manager, &root_client);
+  CompositorFrameSinkSupport root_support(
+      nullptr, &manager, root_frame_sink_id, is_root,
+      handles_frame_sink_id_invalidation, needs_sync_points);
 
   // Set up child FrameSink.
-  EmptySurfaceFactoryClient child_client;
   FrameSinkId child_frame_sink_id(2, 2);
-  SurfaceFactory child_factory(child_frame_sink_id, &manager, &child_client);
+  CompositorFrameSinkSupport child_support(
+      nullptr, &manager, child_frame_sink_id, is_root_child,
+      handles_frame_sink_id_invalidation, needs_sync_points);
 
   // Creates a root surface.
   gfx::Rect root_rect(300, 300);
   RenderPass* root_pass = nullptr;
   CompositorFrame root_frame = CreateCompositorFrame(root_rect, &root_pass);
 
   // Add a reference to the child surface on the root surface.
   LocalSurfaceIdAllocator child_allocator;
   LocalSurfaceId child_local_surface_id = child_allocator.GenerateId();
   SurfaceId child_surface_id(child_frame_sink_id, child_local_surface_id);
   gfx::Rect child_rect(200, 200);
   CreateSurfaceDrawQuad(root_pass,
                         gfx::Transform(1.0f, 0.0f, 0.0f, 50.0f,
                                         0.0f, 1.0f, 0.0f, 50.0f,
                                         0.0f, 0.0f, 1.0f, 0.0f,
                                         0.0f, 0.0f, 0.0f, 1.0f),
                         root_rect,
                         child_rect,
                         child_surface_id);
 
   // Submit the root frame.
   LocalSurfaceIdAllocator root_allocator;
   LocalSurfaceId root_local_surface_id = root_allocator.GenerateId();
   SurfaceId root_surface_id(root_frame_sink_id, root_local_surface_id);
-  root_factory.SubmitCompositorFrame(root_local_surface_id,
-                                     std::move(root_frame),
-                                     SurfaceFactory::DrawCallback());
+  root_support.SubmitCompositorFrame(root_local_surface_id,
+                                     std::move(root_frame));
 
   // Creates a child surface.
   RenderPass* child_pass = nullptr;
   CompositorFrame child_frame = CreateCompositorFrame(child_rect, &child_pass);
 
   // Add a solid quad in the child surface.
   gfx::Rect child_solid_quad_rect(100, 100);
   CreateSolidColorDrawQuad(
       child_pass,
       gfx::Transform(1.0f, 0.0f, 0.0f, 50.0f,
                      0.0f, 1.0f, 0.0f, 50.0f,
                      0.0f, 0.0f, 1.0f, 0.0f,
                      0.0f, 0.0f, 0.0f, 1.0f),
       root_rect, child_solid_quad_rect);
 
   // Submit the frame.
-  child_factory.SubmitCompositorFrame(child_local_surface_id,
-                                      std::move(child_frame),
-                                      SurfaceFactory::DrawCallback());
+  child_support.SubmitCompositorFrame(child_local_surface_id,
+                                      std::move(child_frame));
 
   TestCase tests[] = {
     {
       root_surface_id,
       gfx::Point(10, 10),
       root_surface_id,
       gfx::Point(10, 10)
     },
     {
       root_surface_id,
@@ skipping 32 matching lines @@
   // Submit another root frame, with a slightly perturbed child Surface.
   root_frame = CreateCompositorFrame(root_rect, &root_pass);
   CreateSurfaceDrawQuad(root_pass,
                         gfx::Transform(1.0f, 0.0f, 0.0f, 75.0f,
                                         0.0f, 1.0f, 0.0f, 75.0f,
                                         0.0f, 0.0f, 1.0f, 0.0f,
                                         0.0f, 0.0f, 0.0f, 1.0f),
                         root_rect,
                         child_rect,
                         child_surface_id);
-  root_factory.SubmitCompositorFrame(root_local_surface_id,
-                                     std::move(root_frame),
-                                     SurfaceFactory::DrawCallback());
+  root_support.SubmitCompositorFrame(root_local_surface_id,
+                                     std::move(root_frame));
 
   // Verify that point (100, 100) no longer falls on the child surface.
   // Verify that the transform to the child surface's space has also shifted.
   {
     SurfaceHittest hittest(nullptr, &manager);
 
     gfx::Point point(100, 100);
     gfx::Transform transform;
     EXPECT_EQ(root_surface_id,
               hittest.GetTargetSurfaceAtPoint(root_surface_id, point,
                                               &transform));
     transform.TransformPoint(&point);
     EXPECT_EQ(gfx::Point(100, 100), point);
 
     gfx::Point point_in_target_space(100, 100);
     gfx::Transform target_transform;
     EXPECT_TRUE(hittest.GetTransformToTargetSurface(
         root_surface_id, child_surface_id, &target_transform));
     target_transform.TransformPoint(&point_in_target_space);
     EXPECT_NE(transform, target_transform);
     EXPECT_EQ(gfx::Point(25, 25), point_in_target_space);
   }
 
-  root_factory.EvictSurface();
-  child_factory.EvictSurface();
+  root_support.EvictFrame();
+  child_support.EvictFrame();
 }
 
 // This test verifies that hit testing will progress to the next quad if it
 // encounters an invalid RenderPassDrawQuad for whatever reason.
 TEST(SurfaceHittestTest, Hittest_InvalidRenderPassDrawQuad) {
   SurfaceManager manager;
 
   // Set up root FrameSink.
-  EmptySurfaceFactoryClient root_client;
   FrameSinkId root_frame_sink_id(1, 1);
-  SurfaceFactory root_factory(root_frame_sink_id, &manager, &root_client);
+  CompositorFrameSinkSupport root_support(
+      nullptr, &manager, root_frame_sink_id, is_root,
+      handles_frame_sink_id_invalidation, needs_sync_points);
 
   // Set up child FrameSink.
-  EmptySurfaceFactoryClient child_client;
   FrameSinkId child_frame_sink_id(2, 2);
-  SurfaceFactory child_factory(child_frame_sink_id, &manager, &child_client);
+  CompositorFrameSinkSupport child_support(
+      nullptr, &manager, child_frame_sink_id, is_root_child,
+      handles_frame_sink_id_invalidation, needs_sync_points);
 
   // Creates a root surface.
   gfx::Rect root_rect(300, 300);
   RenderPass* root_pass = nullptr;
   CompositorFrame root_frame = CreateCompositorFrame(root_rect, &root_pass);
 
   // Create a RenderPassDrawQuad to a non-existant RenderPass.
   int invalid_render_pass_id = 1337;
   CreateRenderPassDrawQuad(root_pass, gfx::Transform(), root_rect, root_rect,
                            invalid_render_pass_id);
 
   // Add a reference to the child surface on the root surface.
   LocalSurfaceIdAllocator child_allocator;
   LocalSurfaceId child_local_surface_id = child_allocator.GenerateId();
   SurfaceId child_surface_id(child_frame_sink_id, child_local_surface_id);
   gfx::Rect child_rect(200, 200);
   CreateSurfaceDrawQuad(root_pass,
                         gfx::Transform(1.0f, 0.0f, 0.0f, 50.0f,
                                        0.0f, 1.0f, 0.0f, 50.0f,
                                        0.0f, 0.0f, 1.0f, 0.0f,
                                        0.0f, 0.0f, 0.0f, 1.0f),
                         root_rect,
                         child_rect,
                         child_surface_id);
 
   // Submit the root frame.
   LocalSurfaceIdAllocator root_allocator;
   LocalSurfaceId root_local_surface_id = root_allocator.GenerateId();
   SurfaceId root_surface_id(root_frame_sink_id, root_local_surface_id);
-  root_factory.SubmitCompositorFrame(root_local_surface_id,
-                                     std::move(root_frame),
-                                     SurfaceFactory::DrawCallback());
+  root_support.SubmitCompositorFrame(root_local_surface_id,
+                                     std::move(root_frame));
 
   // Creates a child surface.
   RenderPass* child_pass = nullptr;
   CompositorFrame child_frame = CreateCompositorFrame(child_rect, &child_pass);
 
   // Add a solid quad in the child surface.
   gfx::Rect child_solid_quad_rect(100, 100);
   CreateSolidColorDrawQuad(child_pass,
                            gfx::Transform(1.0f, 0.0f, 0.0f, 50.0f,
                                          0.0f, 1.0f, 0.0f, 50.0f,
                                          0.0f, 0.0f, 1.0f, 0.0f,
                                          0.0f, 0.0f, 0.0f, 1.0f),
                            root_rect,
                            child_solid_quad_rect);
 
   // Submit the frame.
-  child_factory.SubmitCompositorFrame(child_local_surface_id,
-                                      std::move(child_frame),
-                                      SurfaceFactory::DrawCallback());
+  child_support.SubmitCompositorFrame(child_local_surface_id,
+                                      std::move(child_frame));
 
   TestCase tests[] = {
     {
       root_surface_id,
       gfx::Point(10, 10),
       root_surface_id,
       gfx::Point(10, 10)
     },
     {
       root_surface_id,
@@ skipping 22 matching lines @@
     {
       root_surface_id,
       gfx::Point(290, 290),
       root_surface_id,
       gfx::Point(290, 290)
     }
   };
 
   RunTests(nullptr, &manager, tests, arraysize(tests));
 
-  root_factory.EvictSurface();
-  child_factory.EvictSurface();
+  root_support.EvictFrame();
+  child_support.EvictFrame();
 }
 
 TEST(SurfaceHittestTest, Hittest_RenderPassDrawQuad) {
   SurfaceManager manager;
-  EmptySurfaceFactoryClient client;
   FrameSinkId root_frame_sink_id(kArbitraryFrameSinkId);
-  SurfaceFactory factory(root_frame_sink_id, &manager, &client);
+  CompositorFrameSinkSupport support(
+      nullptr, &manager, root_frame_sink_id, is_root,
+      handles_frame_sink_id_invalidation, needs_sync_points);
 
   // Create a CompostiorFrame with two RenderPasses.
   gfx::Rect root_rect(300, 300);
   CompositorFrame root_frame;
   RenderPassList& render_pass_list = root_frame.render_pass_list;
 
   // Create a child RenderPass.
   int child_render_pass_id = 3;
   gfx::Transform transform_to_root_target(1.0f, 0.0f, 0.0f, 50.0f,
                                           0.0f, 1.0f, 0.0f, 50.0f,
@@ skipping 25 matching lines @@
   gfx::Rect child_solid_quad_rect(100, 100);
   CreateSolidColorDrawQuad(child_render_pass,
                            gfx::Transform(),
                            gfx::Rect(100, 100),
                            child_solid_quad_rect);
 
   // Submit the root frame.
   LocalSurfaceIdAllocator root_allocator;
   LocalSurfaceId root_local_surface_id = root_allocator.GenerateId();
   SurfaceId root_surface_id(root_frame_sink_id, root_local_surface_id);
-  factory.SubmitCompositorFrame(root_local_surface_id, std::move(root_frame),
-                                SurfaceFactory::DrawCallback());
+  support.SubmitCompositorFrame(root_local_surface_id, std::move(root_frame));
 
   TestCase tests[] = {
     // These tests just miss the RenderPassDrawQuad.
     {
       root_surface_id,
       gfx::Point(49, 49),
       root_surface_id,
       gfx::Point(49, 49)
     },
     {
@@ skipping 27 matching lines @@
     {
       root_surface_id,
       gfx::Point(100, 100),
       root_surface_id,
       gfx::Point(100, 100)
     }
   };
 
   RunTests(nullptr, &manager, tests, arraysize(tests));
 
-  factory.EvictSurface();
+  support.EvictFrame();
 }
 
 TEST(SurfaceHittestTest, Hittest_SingleSurface_WithInsetsDelegate) {
   SurfaceManager manager;
 
   // Set up root FrameSink.
-  EmptySurfaceFactoryClient root_client;
   FrameSinkId root_frame_sink_id(1, 1);
-  SurfaceFactory root_factory(root_frame_sink_id, &manager, &root_client);
+  CompositorFrameSinkSupport root_support(
+      nullptr, &manager, root_frame_sink_id, is_root,
+      handles_frame_sink_id_invalidation, needs_sync_points);
 
   // Set up child FrameSink.
-  EmptySurfaceFactoryClient child_client;
   FrameSinkId child_frame_sink_id(2, 2);
-  SurfaceFactory child_factory(child_frame_sink_id, &manager, &child_client);
+  CompositorFrameSinkSupport child_support(
+      nullptr, &manager, child_frame_sink_id, is_root,
+      handles_frame_sink_id_invalidation, needs_sync_points);
 
   // Creates a root surface.
   gfx::Rect root_rect(300, 300);
   RenderPass* root_pass = nullptr;
   CompositorFrame root_frame = CreateCompositorFrame(root_rect, &root_pass);
 
   // Add a reference to the child surface on the root surface.
   LocalSurfaceIdAllocator child_allocator;
   LocalSurfaceId child_local_surface_id = child_allocator.GenerateId();
   SurfaceId child_surface_id(child_frame_sink_id, child_local_surface_id);
   gfx::Rect child_rect(200, 200);
   CreateSurfaceDrawQuad(
       root_pass,
       gfx::Transform(1.0f, 0.0f, 0.0f, 50.0f,
                      0.0f, 1.0f, 0.0f, 50.0f,
                      0.0f, 0.0f, 1.0f, 0.0f,
                      0.0f, 0.0f, 0.0f, 1.0f),
       root_rect, child_rect, child_surface_id);
 
   // Submit the root frame.
   LocalSurfaceIdAllocator root_allocator;
   LocalSurfaceId root_local_surface_id = root_allocator.GenerateId();
   SurfaceId root_surface_id(root_frame_sink_id, root_local_surface_id);
-  root_factory.SubmitCompositorFrame(root_local_surface_id,
-                                     std::move(root_frame),
-                                     SurfaceFactory::DrawCallback());
+  root_support.SubmitCompositorFrame(root_local_surface_id,
+                                     std::move(root_frame));
 
   // Creates a child surface.
   RenderPass* child_pass = nullptr;
   CompositorFrame child_frame = CreateCompositorFrame(child_rect, &child_pass);
 
   // Add a solid quad in the child surface.
   gfx::Rect child_solid_quad_rect(190, 190);
   CreateSolidColorDrawQuad(
       child_pass,
       gfx::Transform(1.0f, 0.0f, 0.0f, 5.0f, 0.0f, 1.0f, 0.0f, 5.0f, 0.0f, 0.0f,
                      1.0f, 0.0f, 0.0f, 0.0f, 0.0f, 1.0f),
       root_rect, child_solid_quad_rect);
 
   // Submit the frame.
-  child_factory.SubmitCompositorFrame(child_local_surface_id,
-                                      std::move(child_frame),
-                                      SurfaceFactory::DrawCallback());
+  child_support.SubmitCompositorFrame(child_local_surface_id,
+                                      std::move(child_frame));
 
   TestCase test_expectations_without_insets[] = {
       {root_surface_id, gfx::Point(55, 55), child_surface_id, gfx::Point(5, 5)},
       {root_surface_id, gfx::Point(60, 60), child_surface_id,
        gfx::Point(10, 10)},
       {root_surface_id, gfx::Point(239, 239), child_surface_id,
        gfx::Point(189, 189)},
       {root_surface_id, gfx::Point(244, 244), child_surface_id,
        gfx::Point(194, 194)},
       {root_surface_id, gfx::Point(50, 50), root_surface_id,
@@ skipping 58 matching lines @@
   TestSurfaceHittestDelegate accept_delegate;
   accept_delegate.AddInsetsForAcceptSurface(child_surface_id,
                                             gfx::Insets(5, 5, 5, 5));
   RunTests(&accept_delegate, &manager, test_expectations_with_accept_insets,
            arraysize(test_expectations_with_accept_insets));
 
   // Verify that insets have affected hit targeting.
   EXPECT_EQ(0, accept_delegate.reject_target_overrides());
   EXPECT_EQ(2, accept_delegate.accept_target_overrides());
 
-  root_factory.EvictSurface();
-  child_factory.EvictSurface();
+  root_support.EvictFrame();
+  child_support.EvictFrame();
 }
 
 }  // namespace cc