Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Unified Diff: third_party/WebKit/Source/core/page/FrameTree.cpp

Issue 2795673002: Added UseCounter for clearing browsing context name on cross-origin name (Closed)
Patch Set: Rebase-update Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/FrameTree.cpp
diff --git a/third_party/WebKit/Source/core/page/FrameTree.cpp b/third_party/WebKit/Source/core/page/FrameTree.cpp
index 30fb11c9cd328902411bd98e44a7d53a075537ab..3a55daf3df7db8c656db26a87194d3c55d18351a 100644
--- a/third_party/WebKit/Source/core/page/FrameTree.cpp
+++ b/third_party/WebKit/Source/core/page/FrameTree.cpp
@@ -26,6 +26,7 @@
#include "core/frame/LocalFrame.h"
#include "core/frame/RemoteFrame.h"
#include "core/frame/RemoteFrameView.h"
+#include "core/frame/UseCounter.h"
#include "core/page/Page.h"
#include "wtf/Assertions.h"
#include "wtf/Vector.h"
@@ -47,7 +48,22 @@ FrameTree::FrameTree(Frame* thisFrame)
FrameTree::~FrameTree() {}
+const AtomicString& FrameTree::name() const {
+ // TODO(andypaicu): remove this once we have gathered the data
+ if (m_experimentalSetNulledName) {
+ UseCounter::count(m_thisFrame.get(), UseCounter::CrossOriginMainFrameNulledNameAccessed);
+ }
+ return m_name;
+}
+
+// TODO(andypaicu): remove this once we have gathered the data
+void FrameTree::experimentalSetNulledName() {
+ m_experimentalSetNulledName = true;
+}
+
void FrameTree::setName(const AtomicString& name) {
+ // TODO(andypaicu): remove this once we have gathered the data
+ m_experimentalSetNulledName = false;
m_name = name;
}

Powered by Google App Engine
This is Rietveld 408576698