Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: chrome/android/java/res/layout/data_reduction_main_menu_footer.xml

Issue 2795653006: Add icon to the Data Saver main menu footer and update to spec (Closed)
Patch Set: move graph into bitmap Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/data_reduction_main_menu_footer.xml
diff --git a/chrome/android/java/res/layout/data_reduction_main_menu_footer.xml b/chrome/android/java/res/layout/data_reduction_main_menu_footer.xml
index 15cc470b4b5ee3bee2044db603df5a40687abded..d8e9398d2c3edda8f7b7c49836438d06a64b16d1 100644
--- a/chrome/android/java/res/layout/data_reduction_main_menu_footer.xml
+++ b/chrome/android/java/res/layout/data_reduction_main_menu_footer.xml
@@ -9,24 +9,51 @@
android:id="@+id/data_reduction_footer"
android:layout_width="match_parent"
android:layout_height="wrap_content"
- android:layout_gravity="start"
- android:paddingTop="12dp"
- android:paddingBottom="12dp"
android:orientation="vertical"
- style="@style/AppMenuItem" >
+ android:background="#EDFAFAFA" >
- <TextView
- android:id="@+id/menu_item_text"
- android:layout_width="wrap_content"
- android:layout_height="wrap_content"
- android:text="@string/data_reduction_title"
- android:textAppearance="?android:attr/textAppearanceLargePopupMenu" />
+ <View style="@style/Divider" />
- <TextView
- android:id="@+id/menu_item_summary"
- android:layout_width="wrap_content"
+ <FrameLayout
+ android:layout_width="match_parent"
android:layout_height="wrap_content"
- android:textSize="14sp"
- android:textColor="@color/descriptive_text_color" />
+ android:layout_gravity="start"
+ android:layout_marginTop="@dimen/divider_height"
+ android:paddingTop="12dp"
+ android:paddingBottom="12dp"
+ android:orientation="horizontal"
+ style="@style/AppMenuItem" >
+
+ <ImageView
+ android:id="@+id/chart_icon"
+ android:src="@+drawable/data_reduction_main_menu_icon"
+ android:layout_width="@dimen/data_reduction_main_menu_icon_width"
+ android:layout_height="match_parent"
+ android:layout_gravity="center_vertical"
+ android:contentDescription="@null" />
+
+ <LinearLayout
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:layout_marginStart="@dimen/data_reduction_main_menu_icon_width"
+ android:orientation="vertical"
+ android:paddingStart="16dp" >
+
+ <TextView
+ android:id="@+id/menu_item_text"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:textSize="14sp"
+ android:textAppearance="@style/RobotoMediumStyle" />
+
+ <TextView
+ android:id="@+id/menu_item_summary"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:textSize="14sp"
+ android:textColor="@color/descriptive_text_color" />
+ </LinearLayout>
+
+ </FrameLayout>
</org.chromium.chrome.browser.preferences.datareduction.DataReductionMainMenuFooter>
« no previous file with comments | « chrome/android/java/res/drawable/data_reduction_main_menu_icon.xml ('k') | chrome/android/java/res/values-v17/styles.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698