Add icon to the Data Saver main menu footer and update to spec

chrome/android/java/res/layout/data_reduction_main_menu_footer.xml

Index: chrome/android/java/res/layout/data_reduction_main_menu_footer.xml
diff --git a/chrome/android/java/res/layout/data_reduction_main_menu_footer.xml b/chrome/android/java/res/layout/data_reduction_main_menu_footer.xml
index 15cc470b4b5ee3bee2044db603df5a40687abded..37bb6475a6a0f0c484fce99085f18665cd42aa63 100644
--- a/chrome/android/java/res/layout/data_reduction_main_menu_footer.xml
+++ b/chrome/android/java/res/layout/data_reduction_main_menu_footer.xml
@@ -1,7 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
-<!-- Copyright 2017 The Chromium Authors. All rights reserved.
-     Use of this source code is governed by a BSD-style license that can be
-     found in the LICENSE file. -->
+<!-- Copyright 2017 The Chromium Authors. All rights reserved. Use of this source 
+    code is governed by a BSD-style license that can be found in the LICENSE file. -->
 
 <org.chromium.chrome.browser.preferences.datareduction.DataReductionMainMenuFooter
     xmlns:android="http://schemas.android.com/apk/res/android"
@@ -9,24 +8,46 @@
     android:id="@+id/data_reduction_footer"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
-    android:layout_gravity="start"
-    android:paddingTop="12dp"
-    android:paddingBottom="12dp"
-    android:orientation="vertical"
-    style="@style/AppMenuItem" >
-
-    <TextView
-        android:id="@+id/menu_item_text"
-        android:layout_width="wrap_content"
-        android:layout_height="wrap_content"
-        android:text="@string/data_reduction_title"
-        android:textAppearance="?android:attr/textAppearanceLargePopupMenu" />
+    android:orientation="vertical">
+
+    <View style="@style/Divider"/>

[Ted C, 2017/04/05 17:32:13]

Instead of the outer view being a linearlayout, can it be a framelayout?

I wonder if this layout could be flatten a bit to something like:

<FrameLayout
   width=match_parent
   height=wrap_content>
   <Divider>
   <Image
       layout_marginTop="divider_height"
       height=match_parent
       width=<explicit width in dp>
       gravity/center-ing bits />
   <LinearLayout
       layout_marginStart="image width in dp"
       layout_marginTop="divider_height"
       height=wrap_content
       width=match_parent>
       <Text-y things>
   </LinearLayout>
</FrameLayout>

I think the layout system should be able to handle the alignment we are looking
without the nested layouts...i think.  But oh have I been wrong in the past.

[megjablon, 2017/04/06 22:01:34]

I played around with this a little, but I'd like to keep all the content in a
layout that has the AppMenuItem style so that if the padding changes the item
stays aligned with those in the menu. The divider needs to go above that so even
if I switch layout types, I would want another layout to wrap all the content in
below the divider. If you're not worried about keeping the AppMenuItem style
then I can do this.

 
-    <TextView
-        android:id="@+id/menu_item_summary"
-        android:layout_width="wrap_content"
+    <LinearLayout
+        android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        android:textSize="14sp"
-        android:textColor="@color/descriptive_text_color" />
+        android:layout_gravity="start"
+        android:paddingTop="12dp"
+        android:paddingBottom="12dp"
+        android:orientation="horizontal"
+        style="@style/AppMenuItem">
+
+        <ImageView
+            android:id="@+id/menu_item_icon"
+            android:layout_width="wrap_content"
+            android:layout_height="match_parent"
+            android:contentDescription="@null" />
+
+        <LinearLayout
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:orientation="vertical"
+            android:paddingStart="16dp">
+
+            <TextView
+                android:id="@+id/menu_item_text"
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                android:textSize="14sp"
+                android:textAppearance="@style/RobotoMediumStyle" />
+
+            <TextView
+                android:id="@+id/menu_item_summary"
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                android:textSize="14sp"
+                android:textColor="@color/descriptive_text_color" />
+        </LinearLayout>
+
+    </LinearLayout>
 
 </org.chromium.chrome.browser.preferences.datareduction.DataReductionMainMenuFooter>