Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2795653005: Print the correct path to dartfmt in the presubmit error message. (Closed)

Created:
3 years, 8 months ago by Jacob
Modified:
3 years, 8 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Print the correct path to dartfmt in the presubmit error message. BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/774f261165d39615fffd08d06516261992334ee6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
3 years, 8 months ago (2017-04-04 23:09:52 UTC) #2
Jennifer Messerly
lgtm, thank you!
3 years, 8 months ago (2017-04-04 23:13:09 UTC) #3
Jacob
3 years, 8 months ago (2017-04-04 23:13:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
774f261165d39615fffd08d06516261992334ee6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698