third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp - Issue 2795593006: Abstract out Modulator from V8PerContextData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp

Issue 2795593006: Abstract out Modulator from V8PerContextData (Closed)

Patch Set: Add new from method for Modulator Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp

index af36c3de58677f35ce528c4b78a050673fd9b618..7d4f9c36646ac4069b5207e7c61b2a4244f9fdd7 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp

@@ -84,7 +84,7 @@ v8::MaybeLocal<v8::Module> ScriptModule::resolveModuleCallback(

v8::Local<v8::String> specifier,

v8::Local<v8::Module> referrer) {

v8::Isolate* isolate = context->GetIsolate();

- Modulator* modulator = V8PerContextData::from(context)->modulator();

+ Modulator* modulator = Modulator::from(V8PerContextData::from(context));

DCHECK(modulator);

ScriptModule referrerRecord(isolate, referrer);