Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp

Issue 2795593006: Abstract out Modulator from V8PerContextData (Closed)
Patch Set: Fix tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp
index 1858130f979d45b9560496c44f1e500c446acfeb..d5aae542bf5c1971fdf07e4fb5ca5efc3d4d2fa2 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp
@@ -34,7 +34,6 @@
#include "bindings/core/v8/ScriptState.h"
#include "bindings/core/v8/V8Binding.h"
#include "bindings/core/v8/V8ObjectConstructor.h"
-#include "core/dom/Modulator.h"
#include "platform/InstanceCounters.h"
#include "wtf/PtrUtil.h"
#include "wtf/StringExtras.h"
@@ -189,14 +188,16 @@ void V8PerContextData::addCustomElementBinding(
m_customElementBindings.push_back(std::move(binding));
}
-void V8PerContextData::setModulator(Modulator* modulator) {
- DCHECK(!m_modulator);
- DCHECK(modulator);
- m_modulator = modulator;
+void V8PerContextData::addData(const char* key, Data* data) {
+ m_dataMap.set(key, data);
}
-void V8PerContextData::clearModulator() {
- m_modulator = nullptr;
+void V8PerContextData::clearData(const char* key) {
+ m_dataMap.erase(key);
+}
+
+V8PerContextData::Data* V8PerContextData::getData(const char* key) {
+ return m_dataMap.at(key);
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h ('k') | third_party/WebKit/Source/core/dom/Modulator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698