Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptModuleTest.cpp

Issue 2795593006: Abstract out Modulator from V8PerContextData (Closed)
Patch Set: Fix tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptModuleTest.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptModuleTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptModuleTest.cpp
index 44bd1161891472c8b88600761023322bfc51f982..e46c01989b7aa4f7aa5fc9ee748b630e3ee25107 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptModuleTest.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptModuleTest.cpp
@@ -147,8 +147,7 @@ TEST(ScriptModuleTest, instantiateNoDeps) {
auto modulator = new ScriptModuleTestModulator();
auto resolver = modulator->testScriptModuleResolver();
- auto contextData = V8PerContextData::from(scope.context());
- contextData->setModulator(modulator);
+ Modulator::setModulator(&scope.frame(), modulator);
ScriptModule module = ScriptModule::compile(
scope.isolate(), "export const a = 42;", "foo.js", SharableCrossOrigin);
@@ -165,8 +164,7 @@ TEST(ScriptModuleTest, instantiateWithDeps) {
auto modulator = new ScriptModuleTestModulator();
auto resolver = modulator->testScriptModuleResolver();
- auto contextData = V8PerContextData::from(scope.context());
- contextData->setModulator(modulator);
+ Modulator::setModulator(&scope.frame(), modulator);
ScriptModule moduleA = ScriptModule::compile(
scope.isolate(), "export const a = 'a';", "foo.js", SharableCrossOrigin);

Powered by Google App Engine
This is Rietveld 408576698