Don't force the download notifier to unbind

chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.download;
 
 import android.annotation.TargetApi;
 import android.app.DownloadManager;
 import android.app.Notification;
 import android.app.NotificationManager;
@@ skipping 90 matching lines @@
     private static final int STARTING_NOTIFICATION_ID = 1000000;
     private static final int MAX_RESUMPTION_ATTEMPT_LEFT = 5;
     @VisibleForTesting static final long SECONDS_PER_MINUTE = TimeUnit.MINUTES.toSeconds(1);
     @VisibleForTesting static final long SECONDS_PER_HOUR = TimeUnit.HOURS.toSeconds(1);
     @VisibleForTesting static final long SECONDS_PER_DAY = TimeUnit.DAYS.toSeconds(1);
 
     private static final String KEY_AUTO_RESUMPTION_ATTEMPT_LEFT = "ResumptionAttemptLeft";
     private static final String KEY_NEXT_DOWNLOAD_NOTIFICATION_ID = "NextDownloadNotificationId";
 
     /**
-     * An Observer interface that allows other classes to know when this class wants to shut itself
-     * down.  This lets them unbind if necessary.
+     * An Observer interface that allows other classes to know when this class is canceling
+     * downloads.
      */
     public interface Observer {
-        /** Called when this service is about to start attempting to stop itself. */
-        void onServiceShutdownRequested();
-
         /**
          * Called when a download was canceled from the notification.  The implementer is not
          * responsible for canceling the actual download (that should be triggered internally from
          * this class).  The implementer is responsible for using this to do their own tracking
          * related to which downloads might be active in this service.  File downloads don't trigger
          * a cancel event when they are told to cancel downloads, so classes might have no idea that
          * a download stopped otherwise.
          * @param guid The guid of the download that was canceled.
          */
         void onDownloadCanceled(String guid);
@@ skipping 507 matching lines @@
                 // NotificationManager.  The notification is not bound to this service, so any call
                 // to stopForeground() won't affect the notification.
                 cancelSummaryNotification();
             }
         } else {
             // If we don't have a valid summary, just guarantee that we aren't in the foreground for
             // safety.
             stopForegroundInternal(false);
         }
 
-        // Notify all observers that we are requesting a chance to shut down.  This will let any
-        // observers unbind from us if necessary.
-        for (Observer observer : mObservers) observer.onServiceShutdownRequested();
-
         // Stop the service which should start the destruction process.  At this point we should be
-        // (1) a background service and (2) unbound from any clients.
+        // a background service.  We might not be unbound from any clients.  When they unbind we
+        // will shut down.  That is okay because they will only unbind from us when they are ok with
+        // us going away (e.g. we shouldn't be unbound while in the foreground).
         stopSelf();
         return true;
     }
 
     @Override
     public IBinder onBind(Intent intent) {
         return mBinder;
     }
 
     /**
@@ skipping 707 matching lines @@
             return context.getString(R.string.remaining_duration_minutes, minutes);
         } else if (minutes > 0) {
             return context.getString(R.string.remaining_duration_one_minute);
         } else if (seconds == 1) {
             return context.getString(R.string.remaining_duration_one_second);
         } else {
             return context.getString(R.string.remaining_duration_seconds, seconds);
         }
     }
 }