Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 2795473003: [vm service] Collect garbage before getting native allocation samples (Closed)

Created:
3 years, 8 months ago by zra
Modified:
3 years, 8 months ago
Reviewers:
bkonyi, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[vm service] Collect garbage before getting native allocation samples R=bkonyi@google.com Committed: https://github.com/dart-lang/sdk/commit/78706025daa5d48f73d6238ae6ef76a235733234

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -0 lines) Patch
M runtime/observatory/lib/src/elements/native_memory_profiler.dart View 1 chunk +3 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/collect_all_garbage_test.dart View 1 1 chunk +19 lines, -0 lines 0 comments Download
M runtime/vm/service.cc View 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
3 years, 8 months ago (2017-03-31 21:41:10 UTC) #2
bkonyi
LGTM
3 years, 8 months ago (2017-03-31 21:43:04 UTC) #3
zra
3 years, 8 months ago (2017-04-03 16:12:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
78706025daa5d48f73d6238ae6ef76a235733234 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698