Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2795453003: Add additional metrics for subresource filtering. (Closed)
Patch Set: fix tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index cd3b6aa443b104aa05784f81d3a4678e95b541f8..3de4b71d5f18929ddbd40f68c7740026371ea93c 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -121286,7 +121286,8 @@ from previous Chrome versions.
<suffix name="AfterPaint"
label="Limited to the duration of time starting after first paint, for
page loads that reached first paint."/>
- <suffix name="NoCommit" label="Limited to page loads that did not commit."/>
+ <affected-histogram
+ name="PageLoad.Clients.SubresourceFilter.PageTiming.ForegroundDuration"/>
<affected-histogram name="PageLoad.PageTiming.ForegroundDuration"/>
</histogram_suffixes>
@@ -121645,10 +121646,19 @@ from previous Chrome versions.
name="PageLoad.Experimental.PaintTiming.NavigationToFirstMeaningfulPaint"/>
<affected-histogram
name="PageLoad.Experimental.PaintTiming.ParseStartToFirstMeaningfulPaint"/>
+ <affected-histogram name="PageLoad.PageTiming.ForegroundDuration"/>
<affected-histogram
name="PageLoad.PaintTiming.NavigationToFirstContentfulPaint"/>
<affected-histogram
name="PageLoad.PaintTiming.ParseStartToFirstContentfulPaint"/>
+ <affected-histogram
+ name="PageLoad.ParseTiming.ParseBlockedOnScriptExecution"/>
+ <affected-histogram
+ name="PageLoad.ParseTiming.ParseBlockedOnScriptExecutionFromDocumentWrite"/>
+ <affected-histogram name="PageLoad.ParseTiming.ParseBlockedOnScriptLoad"/>
+ <affected-histogram
+ name="PageLoad.ParseTiming.ParseBlockedOnScriptLoadFromDocumentWrite"/>
+ <affected-histogram name="PageLoad.ParseTiming.ParseDuration"/>
</histogram_suffixes>
<histogram_suffixes name="PageLoadMetricsClientsTabRestore" separator="."
@@ -121678,6 +121688,27 @@ from previous Chrome versions.
<affected-histogram name="PageLoad.ParseTiming.NavigationToParseStart"/>
</histogram_suffixes>
+<histogram_suffixes name="PageLoadMetricsMediaPlayed" separator=".">
+ <suffix name="MediaPlayed" label="Limited to pages where media was played."/>
+ <affected-histogram
+ name="PageLoad.Clients.SubresourceFilter.Experimental.Bytes.Cache"/>
+ <affected-histogram
+ name="PageLoad.Clients.SubresourceFilter.Experimental.Bytes.Network"/>
+ <affected-histogram
+ name="PageLoad.Clients.SubresourceFilter.Experimental.Bytes.Total"/>
+ <affected-histogram
+ name="PageLoad.Clients.SubresourceFilter.Experimental.CompletedResources.Cache"/>
+ <affected-histogram
+ name="PageLoad.Clients.SubresourceFilter.Experimental.CompletedResources.Network"/>
+ <affected-histogram
+ name="PageLoad.Clients.SubresourceFilter.Experimental.CompletedResources.Total"/>
+</histogram_suffixes>
+
+<histogram_suffixes name="PageLoadMetricsNoCommit" separator=".">
+ <suffix name="NoCommit" label="Limited to page loads that did not commit."/>
+ <affected-histogram name="PageLoad.PageTiming.ForegroundDuration"/>
+</histogram_suffixes>
+
<histogram_suffixes name="PageLoadMetricsNoEndTime" separator=".">
<suffix name="NoEndTime"
label="The page load had no recorded end time, so an end time was
@@ -121688,6 +121719,23 @@ from previous Chrome versions.
name="PageLoad.Experimental.PageTiming.NavigationToPageEnd"/>
</histogram_suffixes>
+<histogram_suffixes name="PageLoadMetricsNoMediaPlayed" separator=".">
+ <suffix name="NoMediaPlayed"
+ label="Limited to pages where no media was played."/>
+ <affected-histogram
+ name="PageLoad.Clients.SubresourceFilter.Experimental.Bytes.Cache"/>
+ <affected-histogram
+ name="PageLoad.Clients.SubresourceFilter.Experimental.Bytes.Network"/>
+ <affected-histogram
+ name="PageLoad.Clients.SubresourceFilter.Experimental.Bytes.Total"/>
+ <affected-histogram
+ name="PageLoad.Clients.SubresourceFilter.Experimental.CompletedResources.Cache"/>
+ <affected-histogram
+ name="PageLoad.Clients.SubresourceFilter.Experimental.CompletedResources.Network"/>
+ <affected-histogram
+ name="PageLoad.Clients.SubresourceFilter.Experimental.CompletedResources.Total"/>
+</histogram_suffixes>
+
<histogram_suffixes name="PageLoadMetricsUserGesture" separator=".">
<suffix name="UserGesture"
label="Restricted to pages loaded via a user gesture."/>
« no previous file with comments | « chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698