Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h

Issue 2795453003: Add additional metrics for subresource filtering. (Closed)
Patch Set: add histograms.xml entries Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h
index ebc9b3cc63d6677e10f746e42fad159327362175..c9580cf1a1d6862ae2769fa0350729515ea1ccba 100644
--- a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h
@@ -22,9 +22,27 @@ extern const char kHistogramSubresourceFilterTotalBytes[];
extern const char kHistogramSubresourceFilterNetworkBytes[];
extern const char kHistogramSubresourceFilterCacheBytes[];
+extern const char kHistogramSubresourceFilterMediaTotalResources[];
+extern const char kHistogramSubresourceFilterMediaNetworkResources[];
+extern const char kHistogramSubresourceFilterMediaCacheResources[];
+extern const char kHistogramSubresourceFilterMediaTotalBytes[];
+extern const char kHistogramSubresourceFilterMediaNetworkBytes[];
+extern const char kHistogramSubresourceFilterMediaCacheBytes[];
+
extern const char kHistogramSubresourceFilterDomContentLoaded[];
extern const char kHistogramSubresourceFilterLoad[];
+extern const char kHistogramSubresourceFilterParseDuration[];
+extern const char kHistogramSubresourceFilterParseBlockedOnScriptLoad[];
+extern const char
+ kHistogramSubresourceFilterParseBlockedOnScriptLoadDocumentWrite[];
+extern const char kHistogramSubresourceFilterParseBlockedOnScriptExecution[];
+extern const char
+ kHistogramSubresourceFilterParseBlockedOnScriptExecutionDocumentWrite[];
+
+extern const char kHistogramSubresourceFilterForegroundDuration[];
+extern const char kHistogramSubresourceFilterForegroundDurationAfterPaint[];
+
extern const char kHistogramSubresourceFilterCount[];
extern const char kHistogramSubresourceFilterActivationDecision[];
@@ -47,6 +65,8 @@ class SubresourceFilterMetricsObserver
const page_load_metrics::PageLoadExtraInfo& info) override;
void OnLoadedResource(
const page_load_metrics::ExtraRequestInfo& extra_request_info) override;
+ void OnParseStop(const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info) override;
void OnFirstContentfulPaint(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) override;
@@ -61,10 +81,14 @@ class SubresourceFilterMetricsObserver
const page_load_metrics::PageLoadExtraInfo& extra_info) override;
void OnLoadingBehaviorObserved(
const page_load_metrics::PageLoadExtraInfo& extra_info) override;
+ void MediaStartedPlaying(
+ const content::WebContentsObserver::MediaPlayerInfo& video_type,
+ bool is_in_main_frame) override;
private:
void OnGoingAway(const page_load_metrics::PageLoadTiming& timing,
- const page_load_metrics::PageLoadExtraInfo& info);
+ const page_load_metrics::PageLoadExtraInfo& info,
+ base::TimeTicks app_background_time);
int64_t network_bytes_ = 0;
int64_t cache_bytes_ = 0;
@@ -73,6 +97,7 @@ class SubresourceFilterMetricsObserver
int num_cache_resources_ = 0;
bool subresource_filter_observed_ = false;
+ bool played_media_ = false;
DISALLOW_COPY_AND_ASSIGN(SubresourceFilterMetricsObserver);
};

Powered by Google App Engine
This is Rietveld 408576698