tools/metrics/histograms/histograms.xml - Issue 2795453003: Add additional metrics for subresource filtering.

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2795453003: Add additional metrics for subresource filtering. (Closed)

Patch Set: add histograms.xml entries Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc ('K') | « chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index cd3b6aa443b104aa05784f81d3a4678e95b541f8..6336a714584f53ca6852f1ae39fd663a50676d75 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -121283,6 +121283,8 @@ from previous Chrome versions.

</histogram_suffixes>

<histogram_suffixes name="PageLoadMetricsAfterPaint" separator=".">

+ <affected-histogram

+ name="PageLoad.Clients.SubresourceFilter.PageTiming.ForegroundDuration"/>

<suffix name="AfterPaint"

label="Limited to the duration of time starting after first paint, for

page loads that reached first paint."/>

@@ -121645,10 +121647,19 @@ from previous Chrome versions.

name="PageLoad.Experimental.PaintTiming.NavigationToFirstMeaningfulPaint"/>

<affected-histogram

name="PageLoad.Experimental.PaintTiming.ParseStartToFirstMeaningfulPaint"/>

+ <affected-histogram name="PageLoad.PageTiming.ForegroundDuration"/>

<affected-histogram

name="PageLoad.PaintTiming.NavigationToFirstContentfulPaint"/>

<affected-histogram

name="PageLoad.PaintTiming.ParseStartToFirstContentfulPaint"/>

+ <affected-histogram

+ name="PageLoad.ParseTiming.ParseBlockedOnScriptExecution"/>

+ <affected-histogram

+ name="PageLoad.ParseTiming.ParseBlockedOnScriptExecutionFromDocumentWrite"/>

+ <affected-histogram name="PageLoad.ParseTiming.ParseBlockedOnScriptLoad"/>

+ <affected-histogram

+ name="PageLoad.ParseTiming.ParseBlockedOnScriptLoadFromDocumentWrite"/>

+ <affected-histogram name="PageLoad.ParseTiming.ParseDuration"/>

</histogram_suffixes>

<histogram_suffixes name="PageLoadMetricsClientsTabRestore" separator="."

@@ -121678,6 +121689,22 @@ from previous Chrome versions.

<affected-histogram name="PageLoad.ParseTiming.NavigationToParseStart"/>

</histogram_suffixes>

+<histogram_suffixes name="PageLoadMetricsMediaPlayed" separator=".">

+ <suffix name="AfterPaint" label="Limited to pages where media was played."/>

Ilya Sherman 2017/04/04 21:01:51 Is this the correct suffix name, or did you mean t

Bryan McQuade 2017/04/05 16:04:40 Thanks for catching this! Foxed, thanks!

+ <affected-histogram

+ name="PageLoad.Clients.SubresourceFilter.Experimental.Bytes.Cache"/>

+ <affected-histogram

+ name="PageLoad.Clients.SubresourceFilter.Experimental.Bytes.Network"/>

+ <affected-histogram

+ name="PageLoad.Clients.SubresourceFilter.Experimental.Bytes.Total"/>

+ <affected-histogram

+ name="PageLoad.Clients.SubresourceFilter.Experimental.CompletedResources.Cache"/>

+ <affected-histogram

+ name="PageLoad.Clients.SubresourceFilter.Experimental.CompletedResources.Network"/>

+ <affected-histogram

+ name="PageLoad.Clients.SubresourceFilter.Experimental.CompletedResources.Total"/>

+</histogram_suffixes>

<histogram_suffixes name="PageLoadMetricsNoEndTime" separator=".">

<suffix name="NoEndTime"

label="The page load had no recorded end time, so an end time was