Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Unified Diff: printing/print_settings_conversion.cc

Issue 2795453002: Use DPI from Print Preview on Windows, handle non square (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: printing/print_settings_conversion.cc
diff --git a/printing/print_settings_conversion.cc b/printing/print_settings_conversion.cc
index 19424603808e7032d4b6853e2fac44c2bb8e329d..c7b1a3dc75f30c69d4826e2b13d0dc56c8f02d87 100644
--- a/printing/print_settings_conversion.cc
+++ b/printing/print_settings_conversion.cc
@@ -178,7 +178,6 @@ bool PrintSettingsFromJobSettings(const base::DictionaryValue& job_settings,
int copies = 1;
int scale_factor = 100;
bool rasterize_pdf = false;
-
if (!job_settings.GetBoolean(kSettingCollate, &collate) ||
!job_settings.GetInteger(kSettingCopies, &copies) ||
!job_settings.GetInteger(kSettingColor, &color) ||
@@ -189,6 +188,14 @@ bool PrintSettingsFromJobSettings(const base::DictionaryValue& job_settings,
!job_settings.GetBoolean(kSettingRasterizePdf, &rasterize_pdf)) {
return false;
}
+#if defined(OS_WIN)
+ int dpi_horizontal = 0;
+ int dpi_vertical = 0;
+ if (!job_settings.GetInteger(kSettingDpiHorizontal, &dpi_horizontal) ||
+ !job_settings.GetInteger(kSettingDpiVertical, &dpi_vertical)) {
+ return false;
+ }
+#endif
settings->set_collate(collate);
settings->set_copies(copies);
@@ -203,6 +210,7 @@ bool PrintSettingsFromJobSettings(const base::DictionaryValue& job_settings,
bool can_modify = false;
if (job_settings.GetBoolean(kSettingPreviewModifiable, &can_modify))
settings->set_print_text_with_gdi(can_modify);
+ settings->set_dpi(dpi_horizontal, dpi_vertical);
#endif
return true;

Powered by Google App Engine
This is Rietveld 408576698