Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Unified Diff: components/printing/browser/print_manager_utils.cc

Issue 2795453002: Use DPI from Print Preview on Windows, handle non square (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/printing/browser/print_manager_utils.cc
diff --git a/components/printing/browser/print_manager_utils.cc b/components/printing/browser/print_manager_utils.cc
index ec383a232d2d464764ce37b364e9e17c13264f4e..e948b8bf786d8458f8563d508b176f6c4ab17606 100644
--- a/components/printing/browser/print_manager_utils.cc
+++ b/components/printing/browser/print_manager_utils.cc
@@ -23,8 +23,9 @@ void RenderParamsFromPrintSettings(const PrintSettings& settings,
params->margin_left = settings.page_setup_device_units().content_area().x();
params->dpi = settings.dpi();
params->scale_factor = settings.scale_factor();
- // Currently hardcoded at 72dpi. See PrintSettings' constructor.
- params->desired_dpi = settings.desired_dpi();
+ params->desired_dpi = settings.desired_dpi_horizontal() > 0
+ ? settings.desired_dpi_horizontal()
+ : 72;
Lei Zhang 2017/03/31 22:21:13 Can we leave this file with only getter calls, and
rbpotter 2017/04/01 00:08:01 Removed this parameter entirely and used kPointsPe
params->rasterize_pdf = settings.rasterize_pdf();
// Always use an invalid cookie.
params->document_cookie = 0;

Powered by Google App Engine
This is Rietveld 408576698