chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html - Issue 2795353002: WebUI: For cr-dialog, handle Enter keys in paper-inputs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html

Issue 2795353002: WebUI: For cr-dialog, handle Enter keys in paper-inputs. (Closed)

Patch Set: fix test Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html ('k') | chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html » ('j') | chrome/test/data/webui/cr_elements/cr_dialog_test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html

diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html b/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html

index c58be1787feedfe19f052de1ab4c01fd1625c006..3c024fb7ea37d5e9f16c480510e8aa63f01a5101 100644

--- a/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html

+++ b/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html

@@ -2,7 +2,6 @@

-<link rel="import" href="chrome://resources/polymer/v1_0/iron-a11y-keys/iron-a11y-keys.html">

@@ -46,18 +45,14 @@

<div class="title">[[title_]]</div>

- <div>

- <iron-a11y-keys keys="enter" on-keys-pressed="onSaveButtonTap_">

- </iron-a11y-keys>

- <paper-input id="nameInput" label="$i18n{creditCardName}"

- value="{{creditCard.name}}" always-float-label autofocus

- on-input="onCreditCardNameOrNumberChanged_">

- </paper-input>

- <paper-input id="numberInput" label="$i18n{creditCardNumber}"

- value="{{creditCard.cardNumber}}" always-float-label

- on-input="onCreditCardNameOrNumberChanged_">

- </paper-input>

- </div>

+ <paper-input id="nameInput" label="$i18n{creditCardName}"

+ value="{{creditCard.name}}" always-float-label autofocus

+ on-input="onCreditCardNameOrNumberChanged_">

+ </paper-input>

+ <paper-input id="numberInput" label="$i18n{creditCardNumber}"

+ value="{{creditCard.cardNumber}}" always-float-label

+ on-input="onCreditCardNameOrNumberChanged_">

+ </paper-input>

<label>$i18n{creditCardExpiration}</label>

<select class="md-select" id="month" value="[[expirationMonth_]]"