chrome/browser/resources/settings/on_startup_page/startup_url_dialog.js - Issue 2795353002: WebUI: For cr-dialog, handle Enter keys in paper-inputs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/on_startup_page/startup_url_dialog.js

Issue 2795353002: WebUI: For cr-dialog, handle Enter keys in paper-inputs. (Closed)

Patch Set: fix test Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/on_startup_page/startup_url_dialog.html ('k') | chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html » ('j') | chrome/test/data/webui/cr_elements/cr_dialog_test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/on_startup_page/startup_url_dialog.js

diff --git a/chrome/browser/resources/settings/on_startup_page/startup_url_dialog.js b/chrome/browser/resources/settings/on_startup_page/startup_url_dialog.js

index 3b576580d14f9adcebf3369dbd2b61f3394e0642..706bf18fcb542a61094cfdc987d8133eea394bd0 100644

--- a/chrome/browser/resources/settings/on_startup_page/startup_url_dialog.js

+++ b/chrome/browser/resources/settings/on_startup_page/startup_url_dialog.js

@@ -67,15 +67,6 @@ Polymer({

}.bind(this));

- /**

- * @param {!KeyboardEvent} e

- * @private

- */

- onKeypress_: function(e) {

- if (e.key == 'Enter' && !this.$.actionButton.disabled)

- this.onActionButtonTap_();

- },

/** @private */

validate_: function() {

this.browserProxy_.validateStartupPage(this.url_).then(function(isValid) {