WebUI: For cr-dialog, handle Enter keys in paper-inputs.

ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'cr-dialog' is a component for showing a modal dialog. If the
  * dialog is closed via close(), a 'close' event is fired. If the dialog is
  * canceled via cancel(), a 'cancel' event is fired followed by a 'close' event.
  * Additionally clients can inspect the dialog's |returnValue| property inside
  * the 'close' event listener to determine whether it was canceled or just
@@ skipping 95 matching lines @@
   /** @return {!PaperIconButtonElement} */
   getCloseButton: function() {
     return this.$.close;
   },
 
   /**
    * @param {!Event} e
    * @private
    */
   onKeypress_: function(e) {
-    if (e.target != this)
+    if (!e.target)

[dpapad, 2017/04/04 23:46:14]

Is that possible?

[tommycli, 2017/04/05 21:07:07]

Done.

       return;
     if (e.key != 'Enter')
       return;
 
+    // Accept Enter keys from either the dialog, or a child paper-input element.
+    if (e.target != this && e.target.tagName != 'PAPER-INPUT')

[dpapad, 2017/04/04 23:46:14]

Can we add a test for this? You can use a <paper-input> element in the
cr_dialog_tests.js without actually importing the paper-input.html. The browser
will happily create a non-upgraded paper-input element, which will have none of
the actual paper-input's functionality, but it will return 'PAPER-INPUT'  from
tagName.

[tommycli, 2017/04/05 21:07:07]

Done.

+      return;
+
     var actionButton =
         this.querySelector('.action-button:not([disabled]):not([hidden])');
     if (actionButton) {
       actionButton.click();
       e.preventDefault();
     }
   },
 });