Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessConstants.java

Issue 2795333002: [Merge m58] Abstracting parameters passed to child processes on Android. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessConstants.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConstants.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConstants.java
index d4eb121258264ad0c581635fab11a271afc1355f..0830a2d9ffc2013d0dc9b8b79b04ac45b773094f 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConstants.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConstants.java
@@ -7,16 +7,33 @@ package org.chromium.content.browser;
/**
* Constants to be used by child processes.
*/
-public class ChildProcessConstants {
- // Names of items placed in the bind or start command intent, or connection bundle.
- // Used to pass the command line params to child processes.
+public interface ChildProcessConstants {
+ // Below are the names for the items placed in the bind or start command intent.
+ // Note that because that intent maybe reused if a service is restarted, none should be process
+ // specific.
+
+ // Key in the binding Intent's Bundle for the ChromiumLinkerParams.
+ public static final String EXTRA_LINKER_PARAMS =
+ "com.google.android.apps.chrome.extra.linker_params";
+
+ // Key in the binding Intent's Bundle for the type of process the child is.
+ public static final String EXTRA_LIBRARY_PROCESS_TYPE =
+ "com.google.android.apps.chrome.extra.library_process_type";
+
+ // Below are the names for the items placed in the Bundle passed in the
+ // IChildProcessService.setupConnection call, once the connection has been established.
+
+ // Key for the command line.
public static final String EXTRA_COMMAND_LINE =
"com.google.android.apps.chrome.extra.command_line";
- // Used to pass file descriptors to child processes.
+
+ // Key for the file descriptors that should be mapped in the child process..
public static final String EXTRA_FILES = "com.google.android.apps.chrome.extra.extraFiles";
- // Used to pass the CPU core count to child processes.
+
+ // Key for the number of CPU cores.
public static final String EXTRA_CPU_COUNT = "com.google.android.apps.chrome.extra.cpu_count";
- // Used to pass the CPU features mask to child processes.
+
+ // Key for the CPU features mask.
public static final String EXTRA_CPU_FEATURES =
"com.google.android.apps.chrome.extra.cpu_features";
}

Powered by Google App Engine
This is Rietveld 408576698