Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: runtime/vm/debugger.cc

Issue 2795303002: Disable async debugger support until context mismatch issue is resolved. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/async_step_out_test.dart ('k') | runtime/vm/flag_list.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.cc
diff --git a/runtime/vm/debugger.cc b/runtime/vm/debugger.cc
index bf1d25cfcbfb1a6b98af169e4a3dfd38c75388bf..43a9af6871dac05af1fe5935c8fc77ca44e2642a 100644
--- a/runtime/vm/debugger.cc
+++ b/runtime/vm/debugger.cc
@@ -3244,7 +3244,7 @@ void Debugger::CleanupSyntheticAsyncBreakpoint() {
void Debugger::RememberTopFrameAwaiter() {
- if (!FLAG_async_debugger_stepping) {
+ if (!FLAG_async_debugger) {
return;
}
if (stack_trace_->Length() > 0) {
@@ -3256,7 +3256,7 @@ void Debugger::RememberTopFrameAwaiter() {
void Debugger::SetAsyncSteppingFramePointer() {
- if (!FLAG_async_debugger_stepping) {
+ if (!FLAG_async_debugger) {
return;
}
if (stack_trace_->FrameAt(0)->function().IsAsyncClosure() ||
@@ -3296,7 +3296,7 @@ void Debugger::HandleSteppingRequest(DebuggerStackTrace* stack_trace,
OS::Print("HandleSteppingRequest- kStepOver %" Px "\n", stepping_fp_);
}
} else if (resume_action_ == kStepOut) {
- if (FLAG_async_debugger_stepping) {
+ if (FLAG_async_debugger) {
if (stack_trace->FrameAt(0)->function().IsAsyncClosure() ||
stack_trace->FrameAt(0)->function().IsAsyncGenClosure()) {
// Request to step out of an async/async* closure.
@@ -3664,7 +3664,7 @@ RawError* Debugger::PauseStepping() {
ActivationFrame* frame = TopDartFrame();
ASSERT(frame != NULL);
- if (FLAG_async_debugger_stepping) {
+ if (FLAG_async_debugger) {
if ((async_stepping_fp_ != 0) && (top_frame_awaiter_ != Object::null())) {
// Check if the user has single stepped out of an async function with
// an awaiter. The first check handles the case of calling into the
@@ -4301,7 +4301,7 @@ Breakpoint* Debugger::GetBreakpointById(intptr_t id) {
void Debugger::MaybeAsyncStepInto(const Closure& async_op) {
- if (FLAG_async_debugger_stepping && IsSingleStepping()) {
+ if (FLAG_async_debugger && IsSingleStepping()) {
// We are single stepping, set a breakpoint on the closure activation
// and resume execution so we can hit the breakpoint.
AsyncStepInto(async_op);
« no previous file with comments | « runtime/observatory/tests/service/async_step_out_test.dart ('k') | runtime/vm/flag_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698