fix fasta/analyzer KeywordToken.value()

fix fasta/analyzer KeywordToken.value()

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/b5b64e98e9743a7e3d60564ffc0a902b596f8271

[danrubel, 2017-04-04 14:11:48]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[danrubel, 2017-04-04 14:29:39]

danrubel@google.com changed reviewers:
+ scheglov@google.com

[Brian Wilkerson, 2017-04-04 14:48:59]

I don't think there's any problem with the signature change (although we might
need to add some casts to remove warnings). The bigger issue is that analyzer's
parser will need to be updated to allow pseudo-keywords as identifiers if we
plan on an intermediate state in which the analyzer parser is consuming the
fasta tokens.

Other than that, lgtm.

[danrubel, 2017-04-04 14:52:06]

Description was changed from

==========
fix fasta/analyzer KeywordToken.value()
==========

to

==========
fix fasta/analyzer KeywordToken.value()

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b5b64e98e9743a7e3d60564ffc0a902b596f8271
==========

[danrubel, 2017-04-04 14:52:07]

Committed patchset #2 (id:20001) manually as
b5b64e98e9743a7e3d60564ffc0a902b596f8271 (presubmit successful).

[danrubel, 2017-04-04 20:40:44]

On 2017/04/04 14:48:59, Brian Wilkerson wrote:
> The bigger issue is that analyzer's
> parser will need to be updated to allow pseudo-keywords as identifiers if we
> plan on an intermediate state in which the analyzer parser is consuming the
> fasta tokens.

Good point. Something I'll have to address as I merge scanners.