Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 279523003: CoreAnimation: Ensure frames are acked when tab capture is enabled (Closed)

Created:
6 years, 7 months ago by ccameron
Modified:
6 years, 7 months ago
Reviewers:
miu
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

CoreAnimation: Ensure frames are acked when tab capture is enabled If tab capture is enabled, but the window that is being displayed is occluded, then the quality of the broadcast may be negatively impacted by throttling of its presentation. To avoid this, disable throttling the presentation of the windows that are occluded but may be being captured. Do not disable throttling for non-occluded windows, because that will result in the renderer overloading the browser, and frames being dropped by the browser, resulting in unsmooth animation. BUG=350410 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M content/browser/renderer_host/render_widget_host_view_mac.mm View 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ccameron
Small fix. This occlusion API is exciting -- we should use it to throttle backgrounded ...
6 years, 7 months ago (2014-05-08 21:02:35 UTC) #1
miu
lgtm
6 years, 7 months ago (2014-05-09 20:22:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/279523003/1
6 years, 7 months ago (2014-05-09 20:23:18 UTC) #3
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 00:05:38 UTC) #4
Message was sent while issue was closed.
Change committed as 269642

Powered by Google App Engine
This is Rietveld 408576698